]> sourceware.org Git - libabigail.git/commit
Misc reporting fixes/improvements
authorDodji Seketeli <dodji@redhat.com>
Tue, 14 Apr 2015 04:16:00 +0000 (06:16 +0200)
committerDodji Seketeli <dodji@redhat.com>
Tue, 14 Apr 2015 04:16:00 +0000 (06:16 +0200)
commit21adfb066fa3f9dde5185467d075776384881387
tree967f7461accbb1ce832987fd698070b77667a798
parentfc55e7f34385e78d6f875add3ea75a9dd72f8453
Misc reporting fixes/improvements

This patch contains various reporting improvement about how variables
and data member changes are represented, as well as how type changes
are represented.  The number changes itself is not that big, but the
number of adjustments to regression test is.

* src/abg-comparison.cc (distinct_diff::report): Remove spurious
vertical space before reporting size and alignment changes here.
(represent): In the variables/data member overload, report type
changes first.  Then the other changes.
(report_size_and_alignment_changes): Make this report array size
changes too.  Also, make some small adjustments about how type
size/alignment changes are introduced.
(array_diff::report): Now that report_size_and_alignment_changes()
supports size change reporting, just use that function rather than
doing it here.
(corpus_diff::report): Consistently add a space between each
changed function report.  Prefix changed variables with a [C],
just like for functions.
* tests/data/test-abicompat/test0-fn-changed-report-0.txt: Adjust.
* tests/data/test-abicompat/test5-fn-changed-report-0.txt: Likewise.
* tests/data/test-abicompat/test6-var-changed-report-0.txt: Likewise.
* tests/data/test-abidiff/test-qual-type0-report.txt: Likewise.
* tests/data/test-abidiff/test-struct0-report.txt: Likewise.
* tests/data/test-abidiff/test-struct1-report.txt: Likewise.
* tests/data/test-abidiff/test-var0-report.txt: Likewise.
* tests/data/test-diff-dwarf/test-23-diff-arch-report-0.txt: Likewise.
* tests/data/test-diff-dwarf/test0-report.txt: Likewise.
* tests/data/test-diff-dwarf/test1-report.txt: Likewise.
* tests/data/test-diff-dwarf/test10-report.txt: Likewise.
* tests/data/test-diff-dwarf/test11-report.txt: Likewise.
* tests/data/test-diff-dwarf/test13-report.txt: Likewise.
* tests/data/test-diff-dwarf/test15-enum-report.txt: Likewise.
* tests/data/test-diff-dwarf/test2-report.txt: Likewise.
* tests/data/test-diff-dwarf/test20-add-fn-parm-report-0.txt: Likewise.
* tests/data/test-diff-dwarf/test21-redundant-fn-report-0.txt: Likewise.
* tests/data/test-diff-dwarf/test22-changed-parm-c-report-0.txt: Likewise.
* tests/data/test-diff-dwarf/test3-report.txt: Likewise.
* tests/data/test-diff-dwarf/test6-report.txt: Likewise.
* tests/data/test-diff-dwarf/test7-report.txt: Likewise.
* tests/data/test-diff-dwarf/test8-report.txt: Likewise.
* tests/data/test-diff-dwarf/test9-report.txt: Likewise.
* tests/data/test-diff-filter/test0-report.txt: Likewise.
* tests/data/test-diff-filter/test01-report.txt: Likewise.
* tests/data/test-diff-filter/test1-report.txt: Likewise.
* tests/data/test-diff-filter/test10-report.txt: Likewise.
* tests/data/test-diff-filter/test11-report.txt: Likewise.
* tests/data/test-diff-filter/test13-report.txt: Likewise.
* tests/data/test-diff-filter/test14-0-report.txt: Likewise.
* tests/data/test-diff-filter/test14-1-report.txt: Likewise.
* tests/data/test-diff-filter/test15-0-report.txt: Likewise.
* tests/data/test-diff-filter/test15-1-report.txt: Likewise.
* tests/data/test-diff-filter/test16-report-2.txt: Likewise.
* tests/data/test-diff-filter/test16-report.txt: Likewise.
* tests/data/test-diff-filter/test17-0-report.txt: Likewise.
* tests/data/test-diff-filter/test17-1-report.txt: Likewise.
* tests/data/test-diff-filter/test18-report.txt: Likewise.
* tests/data/test-diff-filter/test19-enum-report-1.txt: Likewise.
* tests/data/test-diff-filter/test2-report.txt: Likewise.
* tests/data/test-diff-filter/test20-inline-report-1.txt: Likewise.
* tests/data/test-diff-filter/test21-compatible-vars-report-0.txt: Likewise.
* tests/data/test-diff-filter/test22-compatible-fns-report-0.txt: Likewise.
* tests/data/test-diff-filter/test23-redundant-fn-parm-change-report-0.txt: Likewise.
* tests/data/test-diff-filter/test24-compatible-vars-report-1.txt: Likewise.
* tests/data/test-diff-filter/test25-cyclic-type-report-0.txt: Likewise.
* tests/data/test-diff-filter/test25-cyclic-type-report-1.txt: Likewise.
* tests/data/test-diff-filter/test26-qualified-redundant-node-report-0.txt: Likewise.
* tests/data/test-diff-filter/test26-qualified-redundant-node-report-1.txt: Likewise.
* tests/data/test-diff-filter/test27-redundant-and-filtered-children-nodes-report-0.txt: Likewise.
* tests/data/test-diff-filter/test27-redundant-and-filtered-children-nodes-report-1.txt: Likewise.
* tests/data/test-diff-filter/test27-redundant-and-filtered-children-nodes-report-2.txt: Likewise.
* tests/data/test-diff-filter/test28-redundant-and-filtered-children-nodes-report-0.txt: Likewise.
* tests/data/test-diff-filter/test28-redundant-and-filtered-children-nodes-report-1.txt: Likewise.
* tests/data/test-diff-filter/test3-report.txt: Likewise.
* tests/data/test-diff-filter/test6-report.txt: Likewise.
* tests/data/test-diff-filter/test9-report.txt: Likewise.
* tests/data/test-diff-suppr/test0-type-suppr-report-0.txt: Likewise.
* tests/data/test-diff-suppr/test0-type-suppr-report-3.txt: Likewise.
* tests/data/test-diff-suppr/test1-typedef-suppr-report-0.txt: Likewise.
* tests/data/test-diff-suppr/test1-typedef-suppr-report-2.txt: Likewise.
* tests/data/test-diff-suppr/test10-changed-parm-c-report-0.txt: Likewise.
* tests/data/test-diff-suppr/test2-struct-suppr-report-0.txt: Likewise.
* tests/data/test-diff-suppr/test3-struct-suppr-report-0.txt: Likewise.
* tests/data/test-diff-suppr/test3-struct-suppr-report-1.txt: Likewise.
* tests/data/test-diff-suppr/test3-struct-suppr-report-2.txt: Likewise.
* tests/data/test-diff-suppr/test4-local-suppr-report-0.txt: Likewise.
* tests/data/test-diff-suppr/test4-local-suppr-report-1.txt: Likewise.
* tests/data/test-diff-suppr/test5-fn-suppr-report-0.txt: Likewise.
* tests/data/test-diff-suppr/test5-fn-suppr-report-1.txt: Likewise.
* tests/data/test-diff-suppr/test5-fn-suppr-report-2.txt: Likewise.
* tests/data/test-diff-suppr/test5-fn-suppr-report-3.txt: Likewise.
* tests/data/test-diff-suppr/test5-fn-suppr-report-4.txt: Likewise.
* tests/data/test-diff-suppr/test5-fn-suppr-report-5.txt: Likewise.
* tests/data/test-diff-suppr/test6-fn-suppr-report-0.txt: Likewise.
* tests/data/test-diff-suppr/test6-fn-suppr-report-1.txt: Likewise.
* tests/data/test-diff-suppr/test6-fn-suppr-report-2.txt: Likewise.
* tests/data/test-diff-suppr/test6-fn-suppr-report-3.txt: Likewise.
* tests/data/test-diff-suppr/test7-var-suppr-report-0.txt: Likewise.
* tests/data/test-diff-suppr/test7-var-suppr-report-1.txt: Likewise.
* tests/data/test-diff-suppr/test7-var-suppr-report-2.txt: Likewise.
* tests/data/test-diff-suppr/test7-var-suppr-report-3.txt: Likewise.
* tests/data/test-diff-suppr/test7-var-suppr-report-4.txt: Likewise.
* tests/data/test-diff-suppr/test7-var-suppr-report-7.txt: Likewise.
* tests/data/test-diff-suppr/test7-var-suppr-report-8.txt: Likewise.
* tests/data/test-diff-suppr/test8-redundant-fn-report-0.txt: Likewise.
* tests/data/test-diff-suppr/test8-redundant-fn-report-1.txt: Likewise.
* tests/data/test-diff-suppr/test9-changed-parm-c-report-0.txt: Likewise.
* tests/data/test-diff-suppr/test9-changed-parm-c-report-1.txt: Likewise.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
90 files changed:
src/abg-comparison.cc
tests/data/test-abicompat/test0-fn-changed-report-0.txt
tests/data/test-abicompat/test5-fn-changed-report-0.txt
tests/data/test-abicompat/test6-var-changed-report-0.txt
tests/data/test-abidiff/test-qual-type0-report.txt
tests/data/test-abidiff/test-struct0-report.txt
tests/data/test-abidiff/test-struct1-report.txt
tests/data/test-abidiff/test-var0-report.txt
tests/data/test-diff-dwarf/test-23-diff-arch-report-0.txt
tests/data/test-diff-dwarf/test0-report.txt
tests/data/test-diff-dwarf/test1-report.txt
tests/data/test-diff-dwarf/test10-report.txt
tests/data/test-diff-dwarf/test11-report.txt
tests/data/test-diff-dwarf/test13-report.txt
tests/data/test-diff-dwarf/test15-enum-report.txt
tests/data/test-diff-dwarf/test2-report.txt
tests/data/test-diff-dwarf/test20-add-fn-parm-report-0.txt
tests/data/test-diff-dwarf/test21-redundant-fn-report-0.txt
tests/data/test-diff-dwarf/test22-changed-parm-c-report-0.txt
tests/data/test-diff-dwarf/test3-report.txt
tests/data/test-diff-dwarf/test6-report.txt
tests/data/test-diff-dwarf/test7-report.txt
tests/data/test-diff-dwarf/test8-report.txt
tests/data/test-diff-dwarf/test9-report.txt
tests/data/test-diff-filter/test0-report.txt
tests/data/test-diff-filter/test01-report.txt
tests/data/test-diff-filter/test1-report.txt
tests/data/test-diff-filter/test10-report.txt
tests/data/test-diff-filter/test11-report.txt
tests/data/test-diff-filter/test13-report.txt
tests/data/test-diff-filter/test14-0-report.txt
tests/data/test-diff-filter/test14-1-report.txt
tests/data/test-diff-filter/test15-0-report.txt
tests/data/test-diff-filter/test15-1-report.txt
tests/data/test-diff-filter/test16-report-2.txt
tests/data/test-diff-filter/test16-report.txt
tests/data/test-diff-filter/test17-0-report.txt
tests/data/test-diff-filter/test17-1-report.txt
tests/data/test-diff-filter/test18-report.txt
tests/data/test-diff-filter/test19-enum-report-1.txt
tests/data/test-diff-filter/test2-report.txt
tests/data/test-diff-filter/test20-inline-report-1.txt
tests/data/test-diff-filter/test21-compatible-vars-report-0.txt
tests/data/test-diff-filter/test22-compatible-fns-report-0.txt
tests/data/test-diff-filter/test23-redundant-fn-parm-change-report-0.txt
tests/data/test-diff-filter/test24-compatible-vars-report-1.txt
tests/data/test-diff-filter/test25-cyclic-type-report-0.txt
tests/data/test-diff-filter/test25-cyclic-type-report-1.txt
tests/data/test-diff-filter/test26-qualified-redundant-node-report-0.txt
tests/data/test-diff-filter/test26-qualified-redundant-node-report-1.txt
tests/data/test-diff-filter/test27-redundant-and-filtered-children-nodes-report-0.txt
tests/data/test-diff-filter/test27-redundant-and-filtered-children-nodes-report-1.txt
tests/data/test-diff-filter/test27-redundant-and-filtered-children-nodes-report-2.txt
tests/data/test-diff-filter/test28-redundant-and-filtered-children-nodes-report-0.txt
tests/data/test-diff-filter/test28-redundant-and-filtered-children-nodes-report-1.txt
tests/data/test-diff-filter/test3-report.txt
tests/data/test-diff-filter/test6-report.txt
tests/data/test-diff-filter/test9-report.txt
tests/data/test-diff-suppr/test0-type-suppr-report-0.txt
tests/data/test-diff-suppr/test0-type-suppr-report-3.txt
tests/data/test-diff-suppr/test1-typedef-suppr-report-0.txt
tests/data/test-diff-suppr/test1-typedef-suppr-report-2.txt
tests/data/test-diff-suppr/test10-changed-parm-c-report-0.txt
tests/data/test-diff-suppr/test2-struct-suppr-report-0.txt
tests/data/test-diff-suppr/test3-struct-suppr-report-0.txt
tests/data/test-diff-suppr/test3-struct-suppr-report-1.txt
tests/data/test-diff-suppr/test3-struct-suppr-report-2.txt
tests/data/test-diff-suppr/test4-local-suppr-report-0.txt
tests/data/test-diff-suppr/test4-local-suppr-report-1.txt
tests/data/test-diff-suppr/test5-fn-suppr-report-0.txt
tests/data/test-diff-suppr/test5-fn-suppr-report-1.txt
tests/data/test-diff-suppr/test5-fn-suppr-report-2.txt
tests/data/test-diff-suppr/test5-fn-suppr-report-3.txt
tests/data/test-diff-suppr/test5-fn-suppr-report-4.txt
tests/data/test-diff-suppr/test5-fn-suppr-report-5.txt
tests/data/test-diff-suppr/test6-fn-suppr-report-0.txt
tests/data/test-diff-suppr/test6-fn-suppr-report-1.txt
tests/data/test-diff-suppr/test6-fn-suppr-report-2.txt
tests/data/test-diff-suppr/test6-fn-suppr-report-3.txt
tests/data/test-diff-suppr/test7-var-suppr-report-0.txt
tests/data/test-diff-suppr/test7-var-suppr-report-1.txt
tests/data/test-diff-suppr/test7-var-suppr-report-2.txt
tests/data/test-diff-suppr/test7-var-suppr-report-3.txt
tests/data/test-diff-suppr/test7-var-suppr-report-4.txt
tests/data/test-diff-suppr/test7-var-suppr-report-7.txt
tests/data/test-diff-suppr/test7-var-suppr-report-8.txt
tests/data/test-diff-suppr/test8-redundant-fn-report-0.txt
tests/data/test-diff-suppr/test8-redundant-fn-report-1.txt
tests/data/test-diff-suppr/test9-changed-parm-c-report-0.txt
tests/data/test-diff-suppr/test9-changed-parm-c-report-1.txt
This page took 0.051685 seconds and 5 git commands to generate.