]> sourceware.org Git - glibc.git/commit
posix: execvpe cleanup
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>
Fri, 22 Jan 2016 11:58:49 +0000 (09:58 -0200)
committerAdhemerval Zanella <adhemerval.zanella@linaro.com>
Mon, 7 Mar 2016 03:21:37 +0000 (00:21 -0300)
commit1eb8930608705702d5746e5491bab4e4429fcb83
tree6cf2a5c4a40c7240cc58c1c4e3347f77b699dd67
parentf83bb9b8e97656ae0d3e2a31e859363e2d4d5832
posix: execvpe cleanup

This patch removes all the dynamic allocation on execvpe code and
instead use direct stack allocation.  This is QoI approach to make
it possible use in scenarios where memory is shared with parent
(vfork or clone with CLONE_VM).

For default process spawn (script file without a shebang), stack
allocation is bounded by NAME_MAX plus PATH_MAX plus 1.  Large
file arguments returns an error (ENAMETOOLONG).  This differs than
current GLIBC pratice in general, but it used to limit stack
allocation for large inputs.  Also, path in PATH environment variable
larger than PATH_MAX are ignored.

The shell direct execution exeception, where execve returns ENOEXEC,
might requires a large stack allocation due large input argument list.

Tested on i686, x86_64, powerpc64le, and aarch64.

* posix/execvpe.c (__execvpe): Remove dynamic allocation.
* posix/Makefile (tests): Add tst-execvpe{1,2,3,4,5,6}.
* posix/tst-execvp1.c (do_test): Use a macro to call execvp.
* posix/tst-execvp2.c (do_test): Likewise.
* posix/tst-execvp3.c (do_test): Likewise.
* posix/tst-execvp4.c (do_test): Likewise.
* posix/tst-execvpe1.c: New file.
* posix/tst-execvpe2.c: Likewise.
* posix/tst-execvpe3.c: Likewise.
* posix/tst-execvpe4.c: Likewise.
* posix/tst-execvpe5.c: Likewise.
* posix/tst-execvpe6.c: Likewise.
13 files changed:
ChangeLog
posix/Makefile
posix/execvpe.c
posix/tst-execvp1.c
posix/tst-execvp2.c
posix/tst-execvp3.c
posix/tst-execvp4.c
posix/tst-execvpe1.c [new file with mode: 0644]
posix/tst-execvpe2.c [new file with mode: 0644]
posix/tst-execvpe3.c [new file with mode: 0644]
posix/tst-execvpe4.c [new file with mode: 0644]
posix/tst-execvpe5.c [new file with mode: 0644]
posix/tst-execvpe6.c [new file with mode: 0644]
This page took 0.042628 seconds and 5 git commands to generate.