]> sourceware.org Git - newlib-cygwin.git/commit
Cygwin: Do not show Error dialogs by default
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Wed, 31 Mar 2021 09:38:41 +0000 (11:38 +0200)
committerCorinna Vinschen <corinna@vinschen.de>
Sat, 3 Feb 2024 18:54:50 +0000 (19:54 +0100)
commit07ea90a5d223ea0d30f54acd87d17343b1c35680
tree72c75e4d0b990a04051bcff40d7b46dcd1218623
parentb91d38db37d8088901e47d73a65dadac51e227fb
Cygwin: Do not show Error dialogs by default

...in a non-Cygwin child process.  Backported from MSYS2.
Downstream commit message follows.

In https://github.com/msys2/msys2-runtime/pull/18, we discussed a change
that would allow default Windows error handling of spawned processes to
kick in (such as registered JIT debuggers). We even agreed that it would
make sense to hide this functionality behind a flag, `winjitdebug`.

However, when this got upstreamed as 21ec498d7f (cygwin: use
CREATE_DEFAULT_ERROR_MODE in spawn, 2020-12-09), that flag was deemed
unnecessary.

But it would appear that it _is_ necessary: As reported in
https://github.com/msys2/MSYS2-packages/pull/2414#issuecomment-810841296
this new behavior is pretty disruptive e.g. in CI scenarios.

So let's introduce that `winjitdebug` flag (settable via the environment
variable `MSYS`) at long last.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
winsup/cygwin/environ.cc
winsup/cygwin/globals.cc
winsup/cygwin/spawn.cc
This page took 0.029256 seconds and 5 git commands to generate.