]> sourceware.org Git - lvm2.git/commit - WHATS_NEW
Suppress low-level locking errors and warnings while using --sysinit.
authorPeter Rajnoha <prajnoha@redhat.com>
Tue, 9 Aug 2011 11:44:57 +0000 (11:44 +0000)
committerPeter Rajnoha <prajnoha@redhat.com>
Tue, 9 Aug 2011 11:44:57 +0000 (11:44 +0000)
commitcf9927697bb34bf936767ca285b85f6687e785d7
treea778fe90daaf7a859d5306f747879ae1e0f9edbb
parent0127a9a525cec688e174dbae5b0033682496d78c
Suppress low-level locking errors and warnings while using --sysinit.

Today, we use "suppress_messages" flag (set internally in init_locking fn based
on 'ignorelockingfailure() && getenv("LVM_SUPPRESS_LOCKING_FAILURE_MESSAGES")'.
This way, we can suppress high level messages like "File-based locking
initialisation failed" or "Internal cluster locking initialisation failed".

However, each locking has its own sequence of initialization steps and these
could log some errors as well. It's quite misleading for the user to see such
errors and warnings if the "--sysinit" is used (and so the ignorelockingfailure
&& LVM_SUPPRESS_LOCKING_FAILURE_MESSAGES environment variable). Errors and
warnings from these intermediary steps should be suppressed as well if requested.

This patch propagates the "suppress_messages" flag deeper into locking init
functions. I've also added these flags for other locking types for consistency,
though it's not actually used for no_locking and readonly_locking.
WHATS_NEW
lib/locking/cluster_locking.c
lib/locking/external_locking.c
lib/locking/file_locking.c
lib/locking/locking.c
lib/locking/locking_types.h
lib/locking/no_locking.c
lib/log/log.h
This page took 0.031894 seconds and 5 git commands to generate.