tools/lvresize.c

   1 /*
   2  * Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
   3  * Copyright (C) 2004-2007 Red Hat, Inc. All rights reserved.
   4  *
   5  * This file is part of LVM2.
   6  *
   7  * This copyrighted material is made available to anyone wishing to use,
   8  * modify, copy, or redistribute it subject to the terms and conditions
   9  * of the GNU Lesser General Public License v.2.1.
  10  *
  11  * You should have received a copy of the GNU Lesser General Public License
  12  * along with this program; if not, write to the Free Software Foundation,
  13  * Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  14  */
  15
  16 #include "tools.h"
  17
  18 #define SIZE_BUF 128
  19
  20 struct lvresize_params {
  21         const char *vg_name;
  22         const char *lv_name;
  23
  24         uint32_t stripes;
  25         uint32_t stripe_size;
  26         uint32_t mirrors;
  27
  28         const struct segment_type *segtype;
  29
  30         /* size */
  31         uint32_t extents;
  32         uint64_t size;
  33         sign_t sign;
  34         percent_t percent;
  35
  36         enum {
  37                 LV_ANY = 0,
  38                 LV_REDUCE = 1,
  39                 LV_EXTEND = 2
  40         } resize;
  41
  42         int resizefs;
  43         int nofsck;
  44
  45         int argc;
  46         char **argv;
  47 };
  48
  49 static int validate_stripesize(struct cmd_context *cmd,
  50                                const struct volume_group *vg,
  51                                struct lvresize_params *lp)
  52 {
  53         if (arg_sign_value(cmd, stripesize_ARG, 0) == SIGN_MINUS) {
  54                 log_error("Stripesize may not be negative.");
  55                 return 0;
  56         }
  57
  58         if (arg_uint_value(cmd, stripesize_ARG, 0) > STRIPE_SIZE_LIMIT * 2) {
  59                 log_error("Stripe size cannot be larger than %s",
  60                           display_size(cmd, (uint64_t) STRIPE_SIZE_LIMIT));
  61                 return 0;
  62         }
  63
  64         if (!(vg->fid->fmt->features & FMT_SEGMENTS))
  65                 log_warn("Varied stripesize not supported. Ignoring.");
  66         else if (arg_uint_value(cmd, stripesize_ARG, 0) > vg->extent_size * 2) {
  67                 log_error("Reducing stripe size %s to maximum, "
  68                           "physical extent size %s",
  69                           display_size(cmd,
  70                                        (uint64_t) arg_uint_value(cmd, stripesize_ARG, 0)),
  71                           display_size(cmd, (uint64_t) vg->extent_size));
  72                 lp->stripe_size = vg->extent_size;
  73         } else
  74                 lp->stripe_size = arg_uint_value(cmd, stripesize_ARG, 0);
  75
  76         if (lp->mirrors) {
  77                 log_error("Mirrors and striping cannot be combined yet.");
  78                 return 0;
  79         }
  80         if (lp->stripe_size & (lp->stripe_size - 1)) {
  81                 log_error("Stripe size must be power of 2");
  82                 return 0;
  83         }
  84
  85         return 1;
  86 }
  87
  88 static int confirm_resizefs_reduce(struct cmd_context *cmd,
  89                                    const struct volume_group *vg,
  90                                    const struct logical_volume *lv,
  91                                    const struct lvresize_params *lp)
  92 {
  93         struct lvinfo info;
  94
  95         memset(&info, 0, sizeof(info));
  96
  97         if (!lv_info(cmd, lv, &info, 1, 0) && driver_version(NULL, 0)) {
  98                 log_error("lv_info failed: aborting");
  99                 return 0;
 100         }
 101
 102         if (lp->resizefs && !info.exists) {
 103                 log_error("Logical volume %s must be activated "
 104                           "before resizing filesystem", lp->lv_name);
 105                 return 0;
 106         }
 107
 108         if (info.exists && !lp->resizefs && (lp->resize == LV_REDUCE)) {
 109                 log_warn("WARNING: Reducing active%s logical volume "
 110                          "to %s", info.open_count ? " and open" : "",
 111                          display_size(cmd, (uint64_t) lp->extents *
 112                                       vg->extent_size));
 113
 114                 log_warn("THIS MAY DESTROY YOUR DATA "
 115                          "(filesystem etc.)");
 116
 117                 if (!arg_count(cmd, force_ARG)) {
 118                         if (yes_no_prompt("Do you really want to "
 119                                           "reduce %s? [y/n]: ",
 120                                           lp->lv_name) == 'n') {
 121                                 log_print("Logical volume %s NOT "
 122                                           "reduced", lp->lv_name);
 123                                 return 0;
 124                         }
 125                         if (sigint_caught())
 126                                 return 0;
 127                 }
 128         }
 129
 130         return 1;
 131 }
 132
 133 static int do_resizefs_reduce(const struct cmd_context *cmd,
 134                               const struct volume_group *vg,
 135                               const struct lvresize_params *lp)
 136 {
 137         char lv_path[PATH_MAX];
 138         char size_buf[SIZE_BUF];
 139
 140         if (dm_snprintf(lv_path, PATH_MAX, "%s%s/%s", cmd->dev_dir,
 141                         lp->vg_name, lp->lv_name) < 0) {
 142                 log_error("Couldn't create LV path for %s",
 143                           lp->lv_name);
 144                 return 0;
 145         }
 146
 147         if (dm_snprintf(size_buf, SIZE_BUF, "%" PRIu64,
 148                         (uint64_t) lp->extents * vg->extent_size / 2) < 0) {
 149                 log_error("Couldn't generate new LV size string");
 150                 return 0;
 151         }
 152
 153         if (!lp->nofsck) {
 154                 if (!exec_cmd("fsadm", "check", lv_path, NULL)) {
 155                         stack;
 156                         return 0;
 157                 }
 158         }
 159
 160         if (lp->resize == LV_REDUCE) {
 161                 if (!exec_cmd("fsadm", "resize", lv_path, size_buf)) {
 162                         stack;
 163                         return 0;
 164                 }
 165         }
 166
 167         return 1;
 168 }
 169
 170 static int _lvresize_params(struct cmd_context *cmd, int argc, char **argv,
 171                             struct lvresize_params *lp)
 172 {
 173         const char *cmd_name;
 174         char *st;
 175
 176         lp->sign = SIGN_NONE;
 177         lp->resize = LV_ANY;
 178
 179         cmd_name = command_name(cmd);
 180         if (!strcmp(cmd_name, "lvreduce"))
 181                 lp->resize = LV_REDUCE;
 182         if (!strcmp(cmd_name, "lvextend"))
 183                 lp->resize = LV_EXTEND;
 184
 185         /*
 186          * Allow omission of extents and size if the user has given us
 187          * one or more PVs.  Most likely, the intent was "resize this
 188          * LV the best you can with these PVs"
 189          */
 190         if ((arg_count(cmd, extents_ARG) + arg_count(cmd, size_ARG) == 0) &&
 191             (argc >= 2)) {
 192                 lp->extents = 100;
 193                 lp->percent = PERCENT_PVS;
 194                 lp->sign = SIGN_PLUS;
 195         } else if ((arg_count(cmd, extents_ARG) +
 196                     arg_count(cmd, size_ARG) != 1)) {
 197                 log_error("Please specify either size or extents but not "
 198                           "both.");
 199                 return 0;
 200         }
 201
 202         if (arg_count(cmd, extents_ARG)) {
 203                 lp->extents = arg_uint_value(cmd, extents_ARG, 0);
 204                 lp->sign = arg_sign_value(cmd, extents_ARG, SIGN_NONE);
 205                 lp->percent = arg_percent_value(cmd, extents_ARG, PERCENT_NONE);
 206         }
 207
 208         /* Size returned in kilobyte units; held in sectors */
 209         if (arg_count(cmd, size_ARG)) {
 210                 lp->size = arg_uint64_value(cmd, size_ARG, UINT64_C(0));
 211                 lp->sign = arg_sign_value(cmd, size_ARG, SIGN_NONE);
 212                 lp->percent = PERCENT_NONE;
 213         }
 214
 215         if (lp->resize == LV_EXTEND && lp->sign == SIGN_MINUS) {
 216                 log_error("Negative argument not permitted - use lvreduce");
 217                 return 0;
 218         }
 219
 220         if (lp->resize == LV_REDUCE && lp->sign == SIGN_PLUS) {
 221                 log_error("Positive sign not permitted - use lvextend");
 222                 return 0;
 223         }
 224
 225         lp->resizefs = arg_count(cmd, resizefs_ARG) ? 1 : 0;
 226         lp->nofsck = arg_count(cmd, nofsck_ARG) ? 1 : 0;
 227
 228         if (!argc) {
 229                 log_error("Please provide the logical volume name");
 230                 return 0;
 231         }
 232
 233         lp->lv_name = argv[0];
 234         argv++;
 235         argc--;
 236
 237         if (!(lp->vg_name = extract_vgname(cmd, lp->lv_name))) {
 238                 log_error("Please provide a volume group name");
 239                 return 0;
 240         }
 241
 242         if (!validate_name(lp->vg_name)) {
 243                 log_error("Volume group name %s has invalid characters",
 244                           lp->vg_name);
 245                 return 0;
 246         }
 247
 248         if ((st = strrchr(lp->lv_name, '/')))
 249                 lp->lv_name = st + 1;
 250
 251         lp->argc = argc;
 252         lp->argv = argv;
 253
 254         return 1;
 255 }
 256
 257 static int _lvresize(struct cmd_context *cmd, struct volume_group *vg,
 258                      struct lvresize_params *lp)
 259 {
 260         struct logical_volume *lv;
 261         struct lvinfo info;
 262         uint32_t stripesize_extents = 0;
 263         uint32_t seg_stripes = 0, seg_stripesize = 0, seg_size = 0;
 264         uint32_t seg_mirrors = 0;
 265         uint32_t extents_used = 0;
 266         uint32_t size_rest;
 267         uint32_t pv_extent_count = 0;
 268         alloc_policy_t alloc;
 269         struct logical_volume *lock_lv;
 270         struct lv_list *lvl;
 271         struct lv_segment *seg;
 272         uint32_t seg_extents;
 273         uint32_t sz, str;
 274         struct list *pvh = NULL;
 275         char size_buf[SIZE_BUF];
 276         char lv_path[PATH_MAX];
 277
 278         /* does LV exist? */
 279         if (!(lvl = find_lv_in_vg(vg, lp->lv_name))) {
 280                 log_error("Logical volume %s not found in volume group %s",
 281                           lp->lv_name, lp->vg_name);
 282                 return ECMD_FAILED;
 283         }
 284
 285         if (arg_count(cmd, stripes_ARG)) {
 286                 if (vg->fid->fmt->features & FMT_SEGMENTS)
 287                         lp->stripes = arg_uint_value(cmd, stripes_ARG, 1);
 288                 else
 289                         log_warn("Varied striping not supported. Ignoring.");
 290         }
 291
 292         if (arg_count(cmd, mirrors_ARG)) {
 293                 if (vg->fid->fmt->features & FMT_SEGMENTS)
 294                         lp->mirrors = arg_uint_value(cmd, mirrors_ARG, 1) + 1;
 295                 else
 296                         log_warn("Mirrors not supported. Ignoring.");
 297                 if (arg_sign_value(cmd, mirrors_ARG, 0) == SIGN_MINUS) {
 298                         log_error("Mirrors argument may not be negative");
 299                         return EINVALID_CMD_LINE;
 300                 }
 301         }
 302
 303         if (arg_count(cmd, stripesize_ARG)) {
 304                 if (!validate_stripesize(cmd, vg, lp))
 305                         return EINVALID_CMD_LINE;
 306         }
 307
 308         lv = lvl->lv;
 309
 310         if (lv->status & LOCKED) {
 311                 log_error("Can't resize locked LV %s", lv->name);
 312                 return ECMD_FAILED;
 313         }
 314
 315         alloc = arg_uint_value(cmd, alloc_ARG, lv->alloc);
 316
 317         if (lp->size) {
 318                 if (lp->size % vg->extent_size) {
 319                         if (lp->sign == SIGN_MINUS)
 320                                 lp->size -= lp->size % vg->extent_size;
 321                         else
 322                                 lp->size += vg->extent_size -
 323                                     (lp->size % vg->extent_size);
 324
 325                         log_print("Rounding up size to full physical extent %s",
 326                                   display_size(cmd, (uint64_t) lp->size));
 327                 }
 328
 329                 lp->extents = lp->size / vg->extent_size;
 330         }
 331
 332         if (!(pvh = lp->argc ? create_pv_list(cmd->mem, vg, lp->argc,
 333                                                      lp->argv, 1) : &vg->pvs)) {
 334                 stack;
 335                 return ECMD_FAILED;
 336         }
 337
 338         switch(lp->percent) {
 339                 case PERCENT_VG:
 340                         lp->extents = lp->extents * vg->extent_count / 100;
 341                         break;
 342                 case PERCENT_FREE:
 343                         lp->extents = lp->extents * vg->free_count / 100;
 344                         break;
 345                 case PERCENT_LV:
 346                         lp->extents = lp->extents * lv->le_count / 100;
 347                         break;
 348                 case PERCENT_PVS:
 349                         pv_extent_count = pv_list_extents_free(pvh);
 350                         lp->extents = lp->extents * pv_extent_count / 100;
 351                         break;
 352                 case PERCENT_NONE:
 353                         break;
 354         }
 355
 356         if (lp->sign == SIGN_PLUS)
 357                 lp->extents += lv->le_count;
 358
 359         if (lp->sign == SIGN_MINUS) {
 360                 if (lp->extents >= lv->le_count) {
 361                         log_error("Unable to reduce %s below 1 extent",
 362                                   lp->lv_name);
 363                         return EINVALID_CMD_LINE;
 364                 }
 365
 366                 lp->extents = lv->le_count - lp->extents;
 367         }
 368
 369         if (!lp->extents) {
 370                 log_error("New size of 0 not permitted");
 371                 return EINVALID_CMD_LINE;
 372         }
 373
 374         if (lp->extents == lv->le_count) {
 375                 log_error("New size (%d extents) matches existing size "
 376                           "(%d extents)", lp->extents, lv->le_count);
 377                 return EINVALID_CMD_LINE;
 378         }
 379
 380         seg_size = lp->extents - lv->le_count;
 381
 382         /* Use segment type of last segment */
 383         list_iterate_items(seg, &lv->segments) {
 384                 lp->segtype = seg->segtype;
 385         }
 386
 387         /* FIXME Support LVs with mixed segment types */
 388         if (lp->segtype != arg_ptr_value(cmd, type_ARG, lp->segtype)) {
 389                 log_error("VolumeType does not match (%s)", lp->segtype->name);
 390                 return EINVALID_CMD_LINE;
 391         }
 392
 393         /* If extending, find stripes, stripesize & size of last segment */
 394         if ((lp->extents > lv->le_count) &&
 395             !(lp->stripes == 1 || (lp->stripes > 1 && lp->stripe_size))) {
 396                 list_iterate_items(seg, &lv->segments) {
 397                         if (!seg_is_striped(seg))
 398                                 continue;
 399
 400                         sz = seg->stripe_size;
 401                         str = seg->area_count;
 402
 403                         if ((seg_stripesize && seg_stripesize != sz
 404                              && !lp->stripe_size) ||
 405                             (seg_stripes && seg_stripes != str && !lp->stripes)) {
 406                                 log_error("Please specify number of "
 407                                           "stripes (-i) and stripesize (-I)");
 408                                 return EINVALID_CMD_LINE;
 409                         }
 410
 411                         seg_stripesize = sz;
 412                         seg_stripes = str;
 413                 }
 414
 415                 if (!lp->stripes)
 416                         lp->stripes = seg_stripes;
 417
 418                 if (!lp->stripe_size && lp->stripes > 1) {
 419                         if (seg_stripesize) {
 420                                 log_print("Using stripesize of last segment %s",
 421                                           display_size(cmd, (uint64_t) seg_stripesize));
 422                                 lp->stripe_size = seg_stripesize;
 423                         } else {
 424                                 lp->stripe_size =
 425                                         find_config_tree_int(cmd,
 426                                                         "metadata/stripesize",
 427                                                         DEFAULT_STRIPESIZE) * 2;
 428                                 log_print("Using default stripesize %s",
 429                                           display_size(cmd, (uint64_t) lp->stripe_size));
 430                         }
 431                 }
 432         }
 433
 434         /* If extending, find mirrors of last segment */
 435         if ((lp->extents > lv->le_count)) {
 436                 list_iterate_back_items(seg, &lv->segments) {
 437                         if (seg_is_mirrored(seg))
 438                                 seg_mirrors = lv_mirror_count(seg->lv);
 439                         else
 440                                 seg_mirrors = 0;
 441                         break;
 442                 }
 443                 if (!arg_count(cmd, mirrors_ARG) && seg_mirrors) {
 444                         log_print("Extending %" PRIu32 " mirror images.",
 445                                   seg_mirrors);
 446                         lp->mirrors = seg_mirrors;
 447                 }
 448                 if ((arg_count(cmd, mirrors_ARG) || seg_mirrors) &&
 449                     (lp->mirrors != seg_mirrors)) {
 450                         log_error("Cannot vary number of mirrors in LV yet.");
 451                         return EINVALID_CMD_LINE;
 452                 }
 453         }
 454
 455         /* If reducing, find stripes, stripesize & size of last segment */
 456         if (lp->extents < lv->le_count) {
 457                 extents_used = 0;
 458
 459                 if (lp->stripes || lp->stripe_size || lp->mirrors)
 460                         log_error("Ignoring stripes, stripesize and mirrors "
 461                                   "arguments when reducing");
 462
 463                 list_iterate_items(seg, &lv->segments) {
 464                         seg_extents = seg->len;
 465
 466                         if (seg_is_striped(seg)) {
 467                                 seg_stripesize = seg->stripe_size;
 468                                 seg_stripes = seg->area_count;
 469                         }
 470
 471                         if (seg_is_mirrored(seg))
 472                                 seg_mirrors = lv_mirror_count(seg->lv);
 473                         else
 474                                 seg_mirrors = 0;
 475
 476                         if (lp->extents <= extents_used + seg_extents)
 477                                 break;
 478
 479                         extents_used += seg_extents;
 480                 }
 481
 482                 seg_size = lp->extents - extents_used;
 483                 lp->stripe_size = seg_stripesize;
 484                 lp->stripes = seg_stripes;
 485                 lp->mirrors = seg_mirrors;
 486         }
 487
 488         if (lp->stripes > 1 && !lp->stripe_size) {
 489                 log_error("Stripesize for striped segment should not be 0!");
 490                 return EINVALID_CMD_LINE;
 491         }
 492
 493         if ((lp->stripes > 1)) {
 494                 if (!(stripesize_extents = lp->stripe_size / vg->extent_size))
 495                         stripesize_extents = 1;
 496
 497                 if ((size_rest = seg_size % (lp->stripes * stripesize_extents))) {
 498                         log_print("Rounding size (%d extents) down to stripe "
 499                                   "boundary size for segment (%d extents)",
 500                                   lp->extents, lp->extents - size_rest);
 501                         lp->extents = lp->extents - size_rest;
 502                 }
 503
 504                 if (lp->stripe_size < STRIPE_SIZE_MIN) {
 505                         log_error("Invalid stripe size %s",
 506                                   display_size(cmd, (uint64_t) lp->stripe_size));
 507                         return EINVALID_CMD_LINE;
 508                 }
 509         }
 510
 511         if (lp->extents == lv->le_count) {
 512                 log_error("New size (%d extents) matches existing size "
 513                           "(%d extents)", lp->extents, lv->le_count);
 514                 return EINVALID_CMD_LINE;
 515         }
 516
 517         if (lp->extents < lv->le_count) {
 518                 if (lp->resize == LV_EXTEND) {
 519                         log_error("New size given (%d extents) not larger "
 520                                   "than existing size (%d extents)",
 521                                   lp->extents, lv->le_count);
 522                         return EINVALID_CMD_LINE;
 523                 } else
 524                         lp->resize = LV_REDUCE;
 525         }
 526
 527         if (lp->extents > lv->le_count) {
 528                 if (lp->resize == LV_REDUCE) {
 529                         log_error("New size given (%d extents) not less than "
 530                                   "existing size (%d extents)", lp->extents,
 531                                   lv->le_count);
 532                         return EINVALID_CMD_LINE;
 533                 } else
 534                         lp->resize = LV_EXTEND;
 535         }
 536
 537         if (lp->mirrors && activation() &&
 538             lv_info(cmd, lv, &info, 0, 0) && info.exists) {
 539                 log_error("Mirrors cannot be resized while active yet.");
 540                 return ECMD_FAILED;
 541         }
 542
 543         if (lv_is_origin(lv)) {
 544                 if (lp->resize == LV_REDUCE) {
 545                         log_error("Snapshot origin volumes cannot be reduced "
 546                                   "in size yet.");
 547                         return ECMD_FAILED;
 548                 }
 549
 550                 memset(&info, 0, sizeof(info));
 551
 552                 if (lv_info(cmd, lv, &info, 0, 0) && info.exists) {
 553                         log_error("Snapshot origin volumes can be resized "
 554                                   "only while inactive: try lvchange -an");
 555                         return ECMD_FAILED;
 556                 }
 557         }
 558
 559         if (lp->resize == LV_REDUCE) {
 560                 if (lp->argc)
 561                         log_warn("Ignoring PVs on command line when reducing");
 562         }
 563
 564         if (lp->resize == LV_REDUCE || lp->resizefs) {
 565                 if (!confirm_resizefs_reduce(cmd, vg, lv, lp))
 566                         return ECMD_FAILED;
 567         }
 568
 569         if (lp->resizefs) {
 570                 if (!do_resizefs_reduce(cmd, vg, lp))
 571                     return ECMD_FAILED;
 572         }
 573
 574         if (!archive(vg)) {
 575                 stack;
 576                 return ECMD_FAILED;
 577         }
 578
 579         log_print("%sing logical volume %s to %s",
 580                   (lp->resize == LV_REDUCE) ? "Reduc" : "Extend",
 581                   lp->lv_name,
 582                   display_size(cmd, (uint64_t) lp->extents * vg->extent_size));
 583
 584         if (lp->resize == LV_REDUCE) {
 585                 if (!lv_reduce(lv, lv->le_count - lp->extents)) {
 586                         stack;
 587                         return ECMD_FAILED;
 588                 }
 589         } else if (!lv_extend(lv, lp->segtype, lp->stripes,
 590                               lp->stripe_size, lp->mirrors,
 591                               lp->extents - lv->le_count,
 592                               NULL, 0u, 0u, pvh, alloc)) {
 593                 stack;
 594                 return ECMD_FAILED;
 595         }
 596
 597         /* store vg on disk(s) */
 598         if (!vg_write(vg)) {
 599                 stack;
 600                 return ECMD_FAILED;
 601         }
 602
 603         backup(vg);
 604
 605         /* If snapshot, must suspend all associated devices */
 606         if (lv_is_cow(lv))
 607                 lock_lv = origin_from_cow(lv);
 608         else
 609                 lock_lv = lv;
 610
 611         if (!suspend_lv(cmd, lock_lv)) {
 612                 log_error("Failed to suspend %s", lp->lv_name);
 613                 vg_revert(vg);
 614                 return ECMD_FAILED;
 615         }
 616
 617         if (!vg_commit(vg)) {
 618                 stack;
 619                 resume_lv(cmd, lock_lv);
 620                 return ECMD_FAILED;
 621         }
 622
 623         if (!resume_lv(cmd, lock_lv)) {
 624                 log_error("Problem reactivating %s", lp->lv_name);
 625                 return ECMD_FAILED;
 626         }
 627
 628         log_print("Logical volume %s successfully resized", lp->lv_name);
 629
 630         if (lp->resizefs && (lp->resize == LV_EXTEND)) {
 631                 if (!exec_cmd("fsadm", "resize", lv_path, size_buf)) {
 632                         stack;
 633                         return ECMD_FAILED;
 634                 }
 635         }
 636
 637         return ECMD_PROCESSED;
 638 }
 639
 640 int lvresize(struct cmd_context *cmd, int argc, char **argv)
 641 {
 642         struct lvresize_params lp;
 643         struct volume_group *vg;
 644         int r;
 645
 646         memset(&lp, 0, sizeof(lp));
 647
 648         if (!_lvresize_params(cmd, argc, argv, &lp))
 649                 return EINVALID_CMD_LINE;
 650
 651         log_verbose("Finding volume group %s", lp.vg_name);
 652         if (!(vg = vg_lock_and_read(cmd, lp.vg_name, NULL, LCK_VG_WRITE,
 653                                     CLUSTERED | EXPORTED_VG | LVM_WRITE,
 654                                     CORRECT_INCONSISTENT))) {
 655                 log_error("Volume group %s doesn't exist", lp.vg_name);
 656                 return ECMD_FAILED;
 657         }
 658
 659         if (!(r = _lvresize(cmd, vg, &lp)))
 660                 stack;
 661
 662         unlock_vg(cmd, lp.vg_name);
 663
 664         return r;
 665 }