Bug 731 - addseverity shouldn't strdup the string
Summary: addseverity shouldn't strdup the string
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: libc (show other bugs)
Version: 2.3.4
: P2 normal
Target Milestone: ---
Assignee: Roland McGrath
URL:
Keywords:
Depends on:
Blocks: libc235
  Show dependency treegraph
 
Reported: 2005-02-16 04:35 UTC by Roland McGrath
Modified: 2018-04-20 13:37 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roland McGrath 2005-02-16 04:35:09 UTC
This trunk change is needed on the 2.3 branch.

2005-01-27  Jakub Jelinek  <jakub@redhat.com>

	* stdlib/tst-fmtmsg.c: Include stdlib.h.

2005-01-25  Jakub Jelinek  <jakub@redhat.com>

	* stdlib/fmtmsg.c (addseverity): Remove new_string variable.
	(free_mem): Don't free string.
	* stdlib/tst-fmtmsg.c: Include string.h.
	(main): Add some more tests.

2005-01-14  Ulrich Drepper  <drepper@redhat.com>

	* stdlib/fmtmsg.c (internal_addseverity): Remove incorrect free call.
	* stdlib/tst-fmtmsg.c (main): Add another addseverity test.
Comment 1 cvs-commit@gcc.gnu.org 2005-02-16 10:37:21 UTC
Subject: Bug 731

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-02-16 10:37:06

Modified files:
	stdlib         : tst-fmtmsg.c 

Log message:
	2005-01-27  Jakub Jelinek  <jakub@redhat.com>
	
	[BZ #731]
	* stdlib/tst-fmtmsg.c: Include stdlib.h.
	2005-01-25  Jakub Jelinek  <jakub@redhat.com>
	
	[BZ #731]
	* stdlib/fmtmsg.c (addseverity): Remove new_string variable.
	(free_mem): Don't free string.
	* stdlib/tst-fmtmsg.c: Include string.h.
	(main): Add some more tests.
	2005-01-14  Ulrich Drepper  <drepper@redhat.com>
	
	[BZ #731]
	* stdlib/fmtmsg.c (internal_addseverity): Remove incorrect free call.
	* stdlib/tst-fmtmsg.c (main): Add another addseverity test.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/stdlib/tst-fmtmsg.c.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.1&r2=1.1.6.1

Comment 2 cvs-commit@gcc.gnu.org 2005-02-16 10:37:23 UTC
Subject: Bug 731

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-02-16 10:37:11

Modified files:
	stdlib         : fmtmsg.c 

Log message:
	2005-01-25  Jakub Jelinek  <jakub@redhat.com>
	
	[BZ #731]
	* stdlib/fmtmsg.c (addseverity): Remove new_string variable.
	(free_mem): Don't free string.
	* stdlib/tst-fmtmsg.c: Include string.h.
	(main): Add some more tests.
	2005-01-14  Ulrich Drepper  <drepper@redhat.com>
	
	[BZ #731]
	* stdlib/fmtmsg.c (internal_addseverity): Remove incorrect free call.
	* stdlib/tst-fmtmsg.c (main): Add another addseverity test.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/stdlib/fmtmsg.c.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.15&r2=1.15.4.1

Comment 3 Roland McGrath 2005-04-05 23:59:21 UTC
These changes are in the 2.3 branch as well as the trunk now.