Bug 6798 - lrint() and llrint() do not set errno on domain error
Summary: lrint() and llrint() do not set errno on domain error
Status: NEW
Alias: None
Product: glibc
Classification: Unclassified
Component: math (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Marek Polacek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-31 10:16 UTC by Michael Kerrisk
Modified: 2014-07-04 05:44 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-


Attachments
test program (2.72 KB, text/plain)
2008-07-31 10:18 UTC, Michael Kerrisk
Details
test program (2.72 KB, text/plain)
2008-07-31 10:19 UTC, Michael Kerrisk
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Kerrisk 2008-07-31 10:16:50 UTC
On a domain error, lrint() and llrint() correctly raise an exception, but do
not set errno.  They should set errno to EDOM.

(The same problem afflicts lround(), llround(), see
http://sourceware.org/bugzilla/show_bug.cgi?id=6797)


Background: 
On error, many glibc math functions both set errno and raise an exception
(fetestexcept(3)).  For example, the following  function all do this: acos(),
asin(), cosh(), sinh(), acosh(), asinh(), exp(), exp2(), ldexp(), log(),
log10(), log2().  However, there is much inconsistency.  Some functions raise an
exception, but don't set errno.  Some functions set errno for some errors, but
not others.  A few set errno, but don't raise an exception.  This series of bug
reports documents deviations from what I consider the ideal: all functions
should BOTH set errno AND raise an exception for all errors.

All of these reports relate to tests on glibc 2.8 (as provided by SUSE 11.0).
Comment 1 Michael Kerrisk 2008-07-31 10:18:03 UTC
Created attachment 2861 [details]
test program
Comment 2 Michael Kerrisk 2008-07-31 10:19:16 UTC
Created attachment 2862 [details]
test program

Sample runs showing problem:

$ /tmp/mt_lrint inf
errno == 0
fetestexcept() says:  FE_INVALID
lrint(inf)=-2147483648
0 FE_INVALID normal

$ /tmp/mt_llrint inf
errno == 0
fetestexcept() says:  FE_INVALID
llrint(inf)=-9223372036854775808
0 FE_INVALID normal

$ /tmp/mt_lrint nan
errno == 0
fetestexcept() says:  FE_INVALID
lrint(nan)=-2147483648
0 FE_INVALID normal

$ /tmp/mt_llrint nan
errno == 0
fetestexcept() says:  FE_INVALID
llrint(nan)=-9223372036854775808
0 FE_INVALID normal
Comment 3 Joseph Myers 2012-03-01 16:43:38 UTC
Confirmed with current sources on x86 and x86_64.