Bug 6760 - patch to getmntent() was not applied, so updatedb still indexes network drives
Summary: patch to getmntent() was not applied, so updatedb still indexes network drives
Status: VERIFIED INVALID
Alias: None
Product: cygwin
Classification: Unclassified
Component: Cygwin DLL (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: cygwin-bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-22 14:49 UTC by Jason Spiro
Modified: 2008-08-25 23:13 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Spiro 2008-07-22 14:49:14 UTC
== Problem ==

On Cygwin[1], GNU updatedb tries to index all mapped network drives.[2]  This 
happens because getmntent() returns the wrong fstype.[3]  Someone mailed a 
patch[4] which would fix this, and someone replied[5] it was checked into CVS, 
but it seems from the cvs log[6] that the patch accidentally never got checked 
in.

== Proposed solution ==

*  Check the patch in.

*  The Cygwin volunteers work hard.  I am sure they get more email than is 
humanly possible to handle without making the occasional mistake.  Bugzilla 
will help them keep better track of the numerous patches that come in.  So, I 
propose you edit http://cygwin.com/contrib.html and 
http://www.cygwin.com/lists.html.  Remove the statements saying patches should 
go to cygwin-patches.  Instead, write that patches should go to bugzilla.

== Notes ==

I am taking the liberty of assigning this directly to cgf because it doesn't 
need to be more public.  cgf, I hope you aren't offended.
^ [1].  The problem still occurs for me on what uname says is CYGWIN_NT-5.1 
1.5.25(0.156/4/2) 2008-05-26 20:37 i686.
^ [2].  as I wrote at http://savannah.gnu.org/bugs/?23742#discussion
^ [3].  a quote from http://thread.gmane.org/gmane.os.cygwin/14500/focus=14591 
(posted in 2002)
^ [4].  http://thread.gmane.org/gmane.os.cygwin.patches/3244
^ [5].  http://thread.gmane.org/gmane.os.cygwin.patches/3244/focus=3285
^ [6].  http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/cygwin/path.cc?
cvsroot=src
Comment 1 Christopher Faylor 2008-07-22 15:08:25 UTC
The patch was checked in on 2007/05/15, revision 1.435 to path.cc and 1.98 to
path.h.

Also: The procedure mentioned for submitting patches is exactly as we want it.

We don't want random users submitting bugzilla reports and assigning them to
people they think are appropriate.
Comment 2 Christopher Faylor 2008-07-22 15:09:24 UTC
Fix was already applied.
Comment 3 Jason Spiro 2008-07-22 20:24:10 UTC
> The patch was checked in on 2007/05/15, revision 1.435 to 
> path.cc and 1.98 to path.h.

My mistake.  I thought you forgot to check the patch in, but I now see that 
you checked it in and that the code was later moved to mount.cc.

> Also: The procedure mentioned for submitting patches is 
> exactly as we want it.
> 
> We don't want random users submitting bugzilla reports and 
> assigning them to people they think are appropriate.

I thought this was an embarrassing bug.  I don't like to embarrass people on 
public mailing lists.  I didn't know if the default bugzilla component 
assignee was a list; so I assigned the bug directly to you.

Again: I was mistaken.

Cheers, --j
Comment 4 Jason Spiro 2008-08-25 23:13:05 UTC
Marking as verified invalid.