Bug 5668 - frysk.sys.TestSignalSet failures
Summary: frysk.sys.TestSignalSet failures
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Andrew Cagney
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-25 11:37 UTC by Mark Wielaard
Modified: 2008-01-25 14:42 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
Project(s) to access:
ssh public key:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Wielaard 2008-01-25 11:37:23 UTC 
One of the recent Signal changes made these two tests fail.
It looks like something simple in the string representation changed that caused
these errors. But it would be good if someone more familiar with the Signal
changes could take a look.

There were 2 failures:
1) testSingleToString(frysk.sys.TestSignalSet)junit.framework.ComparisonFailure:
SIGHUP set expected:<......> but was:<...(1)...>
   at frysk.sys.TestSignalSet.testSingleToString(TestRunner)
   at frysk.junit.Runner.runCases(TestRunner)
   at frysk.junit.Runner.runTestCases(TestRunner)
   at TestRunner.main(TestRunner)
2) testMultiToString(frysk.sys.TestSignalSet)junit.framework.ComparisonFailure:
SIGHUP+SIGUSR1 set expected:<...,SIGUSR1...> but was:<...(1),SIGUSR1(10)...>
   at frysk.sys.TestSignalSet.testMultiToString(TestRunner)
   at frysk.junit.Runner.runCases(TestRunner)
   at frysk.junit.Runner.runTestCases(TestRunner)
   at TestRunner.main(TestRunner)
Comment 1 Andrew Cagney 2008-01-25 14:28:02 UTC 
oops
Comment 2 Andrew Cagney 2008-01-25 14:42:33 UTC 
Fix signal ordering; remove hard-wired name tests in TestSignalSet.

frysk-sys/frysk/sys/ChangeLog
2008-01-25  Andrew Cagney  <cagney@redhat.com>

	* Signal.java-sh (compareTo(Object)): Fix ordering.
	* TestSignal.java (testCompareTo()): New.
	* TestSignalSet.java (testSingleToString())
	(testMultiToString()): Do not hard-wire signal names and numbers.