Bug 5376 - Stap does not check incorrect probe point syntax
Summary: Stap does not check incorrect probe point syntax
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: translator (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-21 00:21 UTC by Masami Hiramatsu
Modified: 2008-11-28 17:07 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments
A bugfix patch for wildcard parsing. (1.89 KB, patch)
2007-11-27 23:04 UTC, Masami Hiramatsu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Masami Hiramatsu 2007-11-21 00:21:35 UTC
- 'probe b* g* n {}' is recognized as 'b*g*n'

- 'probe hoge* if(e) {}' is recognized as 'hoge*if()' (concatenate 'hoge*' and 'if')

- 'probe huga? = hoge {}' is recognized as 'huga = hoge' (? is just ignored)

I think all those cases should be treated as incorrect syntaxes.

Thanks,
Comment 1 Masami Hiramatsu 2007-11-27 23:04:09 UTC
Created attachment 2111 [details]
A bugfix patch for wildcard parsing.

This patch will fix the first and the second issue.

With this patch, parser treats '*'(wildcard) in probe points as an alphabet.
However, there is a side-effect that this patch allows consecutive wildcards
(ex. "probe a** {}").

I'm not sure why the consecutive wildcards have been restricted. I think
it could be allowed like as bash.
Comment 2 Frank Ch. Eigler 2008-11-28 17:07:03 UTC
commit 1ad820e finally fixes issue 3.