Bug 5287 - char * * foo ; char** foo ; char **foo
Summary: char * * foo ; char** foo ; char **foo
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Stan Cox
URL:
Keywords:
Depends on:
Blocks: 2246 5294
  Show dependency tree / graph
 
Reported: 2007-11-07 20:51 UTC by Andrew Cagney
Modified: 2007-12-12 14:58 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Cagney 2007-11-07 20:51:20 UTC 
Of the possible print formattings, the first is probably not the best.

This goes back to the question of having the "C" type print code use a tree
walker; rather than hard wiring the C print code in frysk.value.Type.toPrint
Comment 1 Stan Cox 2007-12-12 14:58:02 UTC 
This was addressed in this change to make type display top down:

Change String toPrint() to use StringBuilder.
    
* Type.java (toPrint(StringBuilder, int)): Change signature from Writer
to StringBuilder.
Change all callers.
(String toPrint()): Change to use StringBuilder.
ArrayType.java (toPrint): Use typeStringBuilder for return type.
* CompositeType.java (toPrint): Use memberStringBuilder for members.
* FunctionType.java (toPrint): Use parmStringBuilder for parameters.
    * PointerType.java (toPrint): Detect ptr to array and ptr to function cases.