Bug 5228 - Coldfire msac.w instruction with parallel load is broken.
Summary: Coldfire msac.w instruction with parallel load is broken.
Status: RESOLVED FIXED
Alias: None
Product: binutils
Classification: Unclassified
Component: gas (show other bugs)
Version: 2.19
: P2 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-28 17:17 UTC by Jens Arnold
Modified: 2007-11-07 16:36 UTC (History)
1 user (show)

See Also:
Host:
Target: m68k-elf
Build:
Last reconfirmed:


Attachments
Fix for broken coldfire msac.w instruction with parallel load. (302 bytes, patch)
2007-10-28 17:24 UTC, Jens Arnold
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Arnold 2007-10-28 17:17:53 UTC
Assembling code using the coldfire msac.w instruction with parallel load encodes
completely wrong registers. The corresponding mac.w and also mac.l and msac.l
with parallel load are working properly.

Investigation revealed that the bug is in opcodes/m68k-opc.c: The arguments
string for the 3 msac.w variants is wrong, it must be the same as for the
corresponding mac.w variants. I will attach a patch against HEAD containing the fix.
Comment 1 Jens Arnold 2007-10-28 17:24:26 UTC
Created attachment 2061 [details]
Fix for broken coldfire msac.w instruction with parallel load.

Here's the proposed patch. Works also for older versions when adjusting the
line position.
Comment 2 Nick Clifton 2007-11-07 16:36:49 UTC
Hi Jens,

  Thanks for the patch.  I have checked it in along with this changelog entry.

Cheers
  Nick

opcodes/ChangeLog
2007-11-07  Jens Arnold  <jens@jens-arnold.net>

	PR gas/5228
	* m68k-opc.c (m68k_opcodes): Fix coldfire msac.w instructions with
	parallel loads.