Bug 4917 - permit on-the-fly program/module symbol data transfer
Summary: permit on-the-fly program/module symbol data transfer
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: runtime (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-13 16:30 UTC by Frank Ch. Eigler
Modified: 2008-01-29 21:43 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Ch. Eigler 2007-08-13 16:30:47 UTC
The fix for bug #4916 makes it harder to enable the system to support
dynamically updated module/symbol data.

The scenarios involve probes on libraries or modules that are not yet loaded,
and thus whose addresses cannot be sent to the module at initialization time.
If there was a secure channel available to staprun (and if staprun stayed
running, even if stapio was suspended), then staprun could inform the module
that there was more probe target code coming online.

Another scenario is probing a user program, but having the module anticipate
needing a backtrace for everything - including some libraries not yet loaded.
That library address data would have to be transmitted to the probe well
after initialization.
Comment 1 Masami Hiramatsu 2007-10-10 14:08:23 UTC
I suggest that runtime should disable module_notifier until this bug is fixed,
because it causes pointless warnings when loading other modules.
http://sources.redhat.com/ml/systemtap/2007-q4/msg00065.html
Comment 2 Frank Ch. Eigler 2008-01-29 21:26:02 UTC
This seems like a worsening idea now, and is discordant
with the trend to upload unwind/symbol data at compile time.
Maybe a need will materialize later.
Comment 3 Martin Hunt 2008-01-29 21:42:28 UTC
I remember the discussion months ago about this and I fixed it.  I did not
realize there war a PR opened on it.
Comment 4 Martin Hunt 2008-01-29 21:43:40 UTC
Fixed.
2007-10-12  Martin Hunt  <hunt@redhat.com>
        Changes to separate the symbols from the command channel.

        * cap.c (init_cap): Add CAP_DAC_OVERRIDE.
        * staprun.h: Change init_ctl_channel prototype.
        * ctl.c (init_ctl_channel): Modify to open either
        a command or symbol channel. Use ".cmd" and ".symbols"
        as the new names.
        * mainloop.c (init_stapio): Call init_ctl_channel(0);
        * staprun.c (cleanup): Call stop_symbol_thread().
        (main): Call start_symbol_thread().
        * staprun_funcs.c (handle_symbols): Make a thread.
        (start_symbol_thread): New.
        (stop_symbol_thread): New.