Bug 4299 - System.exit() usage
Summary: System.exit() usage
Status: NEW
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-30 16:25 UTC by Mark Wielaard
Modified: 2007-06-20 08:38 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:
Project(s) to access:
ssh public key:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Wielaard 2007-03-30 16:25:09 UTC 
As pointed out in a comment on bug #4174 System.exit() should not be used to
bail out in bad situations because it doesn't give the gui or the fhpd (or
anything else using frysk as library) a chance to properly notify the user what
happened (and clean things up).

The following classes use System.exit() at this time:

- frysk.rt.RunState
- frysk.util.FCatch
- frysk.util.StacktraceAction
- frysk.util.CoredumpAction
- frysk.gui.srcwin.SourceWindowFactory
- frysk.gui.common.Messages
- frysk.gui.Gui (this is probably the only class that should use it)
Comment 1 Mark Wielaard 2007-06-20 08:38:21 UTC 
The frysk.util.CoredumpAction one was fixed by:

        2007-06-19  Phil Muldoon  <pmuldoon@redhat.com>
        
        * CoredumpAction (AbandonCoreDump): Do not use system.exit,
        instead throw an exception.