Bug 4278 - Get assembly view working
Summary: Get assembly view working
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Mike Cvet
URL:
Keywords:
Depends on:
Blocks: 1633 1711
  Show dependency treegraph
 
Reported: 2007-03-26 14:10 UTC by Mike Cvet
Modified: 2007-03-26 18:17 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Cvet 2007-03-26 14:10:16 UTC
Although the SourceWindow can view the assembly of a non-debuginfo frame, it 
can't explicitly set the current frame (with debuginfo) to show assembly. The 
combobox in the SourceWindow should be enabled and plugged in.
Comment 1 Mike Cvet 2007-03-26 19:17:54 UTC
Log message:
	frysk-gui/frysk/gui:
	2007-03-26  Mike Cvet  <mcvet@redhat.com>
	
	* gladedir/frysk_source.glade: Temporarily removed "Mixed" from
	combobox entries.
	
	frysk-gui/frysk/gui/srcwin:
	2007-03-26  Mike Cvet  <mcvet@redhat.com>
	
	* View.java (load): Now takes an int parameter, setting the mode of
	the view.
	* SourceWindow.java (viewPicker): Added. Combobox variable to select
	source, assembly, or combination display in the Source Window. Fixes
	#1711, #4278.
	(finishSourceWin): Initialize above variable; set default selection.
	(populateStackBrowser): Check for MixedView and SourceView instead of
	assuming SourceView default.
	(getStackView): Added.
	(desensitize): Added entry for viewPicker.
	(resensitize): Ditto.
	(attachEvents): Set viewPicker to sensitive.
	(switchToSourceMode): Set line numbers to true in the SourceView; scroll
	to the appropriate function upon call. Create highlighting tags in the
	SourceBuffer.
	(switchToAsmMode): Remove highlighting tags from the SourceBuffer.
	Remove line numbers.
	(switchToSourceAsmMode): Do nothing if the current frame has no
	debuginfo.
	(updateShownStackFrame): Handle appropriate mode switching between
	source and assembly views. Notify the SourceBuffer which mode to use.
	Differentiate between SourceView and MixedView. Fixes #1711, #4278.
	(removeTags): Differentiate between SourceView and MixedView.
	(createTags): Ditto.
	* SourceView.java (setLineNums): Added. Determines whether or not line
	numbers should be displayed.
	(load): Takes an int parameter for mode.
	* SourceBuffer.java (setScope): Changed to protected. Set global mode
	value at the end of the method. Only highlights text if in source mode.
	(disassembleFrame): Changed output to use frame name.
	(loadAssembly): Removed dummy code. Calls disassembleFrame(), and
	removes text highlighting.
	* MixedView.java: Applied GNU formatting.
	(MixedView): Set line numbers to false for assembly view. Set the
	position of the horizontal split to half the available view real
	estate.
	(load): Explicitly set subwindow modes to either source or assembly.
	(getSourceWidget): Added.
	(getAssemblyWidget): Added.