Bug 3983 - NullPointer in SourceWindow
Summary: NullPointer in SourceWindow
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Mike Cvet
URL:
Keywords:
Depends on:
Blocks: 1633
  Show dependency tree / graph
 
Reported: 2007-02-06 21:48 UTC by Mike Cvet
Modified: 2007-02-06 22:03 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:
Project(s) to access:
ssh public key:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Cvet 2007-02-06 21:48:09 UTC 
Stepping through johntheripper:

java.lang.NullPointerException
   at frysk.gui.srcwin.SourceWindow.populateStackBrowser(FryskGui)
   at frysk.gui.srcwin.SourceWindow$LockObserver$26.run(FryskGui)
   at org.gnu.glib.CustomEvents.runEvents(libgtkjava-2.8.so)
   at org.gnu.gtk.Gtk.gtk_main(libgtkjava-2.8.so)
   at frysk.gui.Gui.gui(FryskGui)
   at frysk.gui.FryskGui.main(FryskGui)
Comment 1 Mike Cvet 2007-02-06 21:52:19 UTC 
StackFrame.java:  

public String getMethodName ()
  {
    if (this.myCursor == null || this.myCursor.getMethodName() == null)
      return null;
    
    return this.myCursor.getMethodName();
  }

This was changed from << return ""; >> in the case of an unresolvable symbol.

Changing back. Sigh.
Comment 2 Mike Cvet 2007-02-06 22:03:28 UTC 
Log message:
	2007-02-06  Mike Cvet  <mcvet@redhat.com>
	
	* StackFrame.java (getMethodName): Return empty strings rather than 
null when the name
	cannot be resolved. Fixes #3983.
	(toPrint): Changed back to checking for empty strings rather than nulls
	for unresolvable symbol names.