Bug 3827 - Code uses Build.SRCDIR
Summary: Code uses Build.SRCDIR
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Andrew Cagney
URL:
Keywords:
Depends on:
Blocks: 3694
  Show dependency treegraph
 
Reported: 2007-01-04 13:43 UTC by Andrew Cagney
Modified: 2008-03-18 14:55 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Cagney 2007-01-04 13:43:24 UTC
Installed code is using Build.SRCDIR, and shouldn't.  Instead, assuming it is
test code checking for a src path, it can use Config.getRootSrcDir.

frysk/util/TestFCatch.java:67:                      + Build.SRCDIR
frysk/util/TestFCatch.java:70:                      + Build.SRCDIR
frysk/util/TestFStack.java:83:                        + Build.SRCDIR
frysk/util/TestFStack.java:86:                        + Build.SRCDIR
frysk/util/TestFStack.java:93:                    + Build.SRCDIR +
"/frysk/pkglibdir/funit-child.c#[\\d]+\n"
frysk/gui/DummySourceWindow.java:206:                        Build.SRCDIR + "/"
+ BASE_PATH + GLADE_PKG_PATH,
frysk/gui/DummySourceWindow.java:214:                        "./common",
Build.SRCDIR + "/" + BASE_PATH + "common/",
frysk/gui/DummySourceWindow.java:218:                       
"./srcwin/testfiles", Build.SRCDIR + "/" + BASE_PATH + "srcwin/testfiles",
frysk/gui/DummyDebugResults.java:135:                        Build.SRCDIR + "/"
+ BASE_PATH + GLADE_PKG_PATH,
frysk/gui/DummyDebugResults.java:143:                        "./common",
Build.SRCDIR + "/" + BASE_PATH + "common/",
frysk/gui/DummyDebugResults.java:147:                       
"./srcwin/testfiles", Build.SRCDIR + "/" + BASE_PATH + "srcwin/testfiles",
frysk/gui/test/TestGlade.java:87:                       Build.SRCDIR + "/" +
BASE_PATH + GLADE_PKG_PATH,
frysk/gui/test/TestParser.java:100:                                    
Build.SRCDIR + "/frysk/gui/srcwin/testfiles/test_looper.xml",
frysk/gui/test/TestParser.java:108:    if (DOMFactory.pathFound(Build.SRCDIR))
frysk/gui/FryskGui.java:56:                  Build.SRCDIR + "/" + BASE_PATH +
GLADE_PKG_PATH,
frysk/gui/FryskGui.java:64:                  "./common", Build.SRCDIR + "/" +
BASE_PATH + "common/",
frysk/gui/FryskGui.java:68:                  "./srcwin/testfiles", Build.SRCDIR
+ "/" + BASE_PATH + "srcwin/testfiles",
Comment 1 Andrew Cagney 2007-01-06 12:55:10 UTC
2007-01-06  Andrew Cagney  <cagney@redhat.com>

	* TestFCatch.java: Use wild cards, instead of Build.SRCDIR.
	* TestFStack.java: Ditto.

Comment 2 Andrew Cagney 2007-01-06 14:58:34 UTC
Index: frysk-core/frysk/pkglibdir/ChangeLog
2007-01-07  Andrew Cagney  <cagney@redhat.com>

        * funit.java: Pass glade and image directories to runTestCases.

Index: frysk-imports/common/ChangeLog
2007-01-07  Andrew Cagney  <cagney@redhat.com>

        * TestRunner.javain: Pass glade, and image directories to
        runTestCases.

Index: frysk-imports/frysk/junit/ChangeLog
2007-01-07  Andrew Cagney  <cagney@redhat.com>

        * TestPaths.java (savedGlade, savedImage, setUp, tearDown): Save
        and restore glade and image prefixes.
        (testCrossedDataPaths, testCrossedExecPaths): Replace
        testCrossPaths.
        * Paths.java (setDataPrefixes, setExecPrefixes): Replace
        setPrefixes.
        (gladePrefix, getGladePrefix, imagePrefix, getImagePrefix): Add.
        * Runner.java: Update.
Comment 3 Andrew Cagney 2008-03-18 14:55:16 UTC
Build.SRCDIR has been eliminated.