Bug 3579 - missing dejagnu doesn't cause make check to fail
Summary: missing dejagnu doesn't cause make check to fail
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Stan Cox
URL:
Keywords:
Depends on:
Blocks: 2234
  Show dependency tree / graph
 
Reported: 2006-11-23 21:13 UTC by Andrew Cagney
Modified: 2006-11-28 17:50 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Cagney 2006-11-23 21:13:21 UTC 
If dejagnu isn't installed, make check appears to just skip over the dejagnu
tests (it prints a warning), it should instead fail.  Otherwize there's an
apparent pass when in fact nothing was tested.

This might turn out to be an automake config thing.

Assign to stan initially as it affects expr.
Comment 1 Andrew Cagney 2006-11-27 15:27:05 UTC 
A possible fix is something like (in common/Makefile.rules?)

check-DEJAGNU: checked-for-dejagnu
CLEANFILES += checked-for-dejagnu
checked-for-dejagnu:
<tab>$(RUNTEST) --help > /dev/null 2>&1
<tab>touch $@

see end of common/Makefile.rules for details.  Might need to hang it off
check-local, or might need to make it local to frysk-core?
Comment 2 Andrew Cagney 2006-11-27 15:32:24 UTC 
FYI, explains why dejagnu failures were missed.
Comment 3 Stan Cox 2006-11-28 17:50:48 UTC 
check-dejagnu is imported by automake from /usr/share/automake-X/am/dejagnu.am
so I piggybacked it onto check-local