While experimenting with porting x86-64 commit aec6b87e0b66 ("[x86] Resolve non-PIC undefweak symbols in executable") to s390 I noticed that linker test ld-x86-64/pr19636-3d.d was added but not listed in ld-x86-64/x86-64.exp with subject commit. Git pickaxe does not report it ever been listed: $ git log -S"pr19636-3d" -- ld/testsuite/ld-x86-64 Adding it to ld-x86-64/x86-64.exp as follow causes this test to fail in the same way it would on s390: diff --git a/ld/testsuite/ld-x86-64/x86-64.exp b/ld/testsuite/ld-x86-64/x86-64.exp --- a/ld/testsuite/ld-x86-64/x86-64.exp +++ b/ld/testsuite/ld-x86-64/x86-64.exp @@ -727,6 +727,7 @@ run_dump_test "pr19636-2m" run_dump_test "pr19636-3a" run_dump_test "pr19636-3b" run_dump_test "pr19636-3c" +run_dump_test "pr19636-3d" run_dump_test "pr19645" run_dump_test "pr19609-1a" run_dump_test "pr19609-1b" Excerpt from ld.log: extra regexps in /home/jremus/git/binutils/ld/testsuite/ld-x86-64/pr19636-3d.d starting with "^Symbol table '\.dynsym' contains [0-9]+ entries:$" EOF from tmpdir/dump.out FAIL: ld-x86-64/pr19636-3d
The master branch has been updated by H.J. Lu <hjl@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=37c6eb16164a2345484777bb5affab45ab502f6f commit 37c6eb16164a2345484777bb5affab45ab502f6f Author: H.J. Lu <hjl.tools@gmail.com> Date: Thu Mar 20 08:43:56 2025 -0700 x86-64: Remove the unused pr19636-3d.d Remove the unused pr19636-3d.d since static Position Dependent Executable doesn't have a dynamic symbol table. PR ld/32807 * testsuite/ld-x86-64/pr19636-3d.d: Removed. Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
Fixed for 2.45.