Bug 3216 - incorrect logger use in frysk.rt.StackCallbacks.java
Summary: incorrect logger use in frysk.rt.StackCallbacks.java
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks: 2935 3076
  Show dependency tree / graph
 
Reported: 2006-09-15 20:51 UTC by Andrew Cagney
Modified: 2007-01-11 22:43 UTC (History)
5 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Cagney 2006-09-15 20:51:29 UTC 
The file contains:
    logger.log(Level.FINE, "Libunwind: findProcInfo for 0x"
                                + Long.toHexString(instructionAddress) + "\n");
(it also contained references to frysk.proc.Host.logger, but that is another
story :-), in particular, note the use of the << + >> operator.  That causes the
allocation of a StringBuffer even when there's no log message.

The code should instead use the logger's formatting mechanism.

(It's suspected that the code was simply translated from System.out.println calls).
Comment 1 Nurdin Premji 2007-01-11 22:43:45 UTC 
Fixed
January 11, 2007
frysk-core/frysk/rt/CL
	* StackCallbacks.java (accessReg): Use logger formatting mechanism, bug #3216
	(accessFpreg): Ditto.
	(getPid): Ditto.
	(writeFpreg): Ditto.
	(writeMem): Ditto.
	(accessMem): Ditto. Cleaned up some excessive logging junk. 
	(writeReg): Ditto.