Bug 31821 - move index_addrmap from dwarf2_per_bfd to mapped_gdb_index
Summary: move index_addrmap from dwarf2_per_bfd to mapped_gdb_index
Status: RESOLVED FIXED
Alias: None
Product: gdb
Classification: Unclassified
Component: symtab (show other bugs)
Version: HEAD
: P2 normal
Target Milestone: 16.1
Assignee: Tom Tromey
URL:
Keywords:
Depends on:
Blocks: 29366
  Show dependency tree / graph
 
Reported: 2024-05-30 15:34 UTC by Tom Tromey
Modified: 2024-05-31 14:31 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Tromey 2024-05-30 15:34:00 UTC 
dwarf2_per_bfd::index_addrmap is only used by the mapped
gdb index.  It should be in mapped_gdb_index instead.
Comment 1 Tom Tromey 2024-05-30 15:34:36 UTC 
Also then find_per_cu can be simplified to call into the
index object.
Comment 2 Tom Tromey 2024-05-30 16:38:53 UTC 
I ended up finding a little time to implement this after all.
Comment 3 Sourceware Commits 2024-05-31 14:26:42 UTC 
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2e3b7a38930730b98e41f1393f8479488debb823

commit 2e3b7a38930730b98e41f1393f8479488debb823
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu May 30 10:39:17 2024 -0600

    Move dwarf2_per_bfd::index_addrmap to mapped_gdb_index
    
    dwarf2_per_bfd::index_addrmap is only used by the .gdb_index reader,
    so this field can be moved to mapped_gdb_index instead.  Then,
    cooked_index_functions::find_per_cu can be removed in favor of a
    method on the index object.
    
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31821
    Approved-By: Simon Marchi <simon.marchi@efficios.com>
Comment 4 Tom Tromey 2024-05-31 14:31:21 UTC 
Fixed.