Bug 30471 - Clean up DAP breakpoint reporting
Summary: Clean up DAP breakpoint reporting
Status: NEW
Alias: None
Product: gdb
Classification: Unclassified
Component: dap (show other bugs)
Version: HEAD
: P2 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-19 14:51 UTC by Tom Tromey
Modified: 2023-12-12 14:58 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Tromey 2023-05-19 14:51:05 UTC 
DAP says that stop events should differentiate between:

    reason: 'step' | 'breakpoint' | 'exception' | 'pause' | 'entry' | 'goto'
        | 'function breakpoint' | 'data breakpoint' | 'instruction breakpoint'
        | string;

Currently this isn't done.
Comment 1 Tom Tromey 2023-06-14 16:27:03 UTC 
I wonder if this is important at all.

Multiple kinds of breakpoints could exist at a given location.
So, differentiating that way doesn't always make sense; and anyway
the stop event will hold the breakpoint IDs.

For this case:

    elif _expected_stop is None:
        # FIXME what is even correct here
        _expected_stop = StopKinds.EXCEPTION

... maybe what we want is bug#13587, so we can report gdb's stop
reason.  This seems fine due to that "| string" clause at the
end of the "reason" description.