Bug 29766 - kernel.function("__set_page_dirty_buffers") not found in tapset/linux/vfs.stp
Summary: kernel.function("__set_page_dirty_buffers") not found in tapset/linux/vfs.stp
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: runtime (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-09 14:00 UTC by Martin Cermak
Modified: 2022-12-14 16:39 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments
possible patch (665 bytes, patch)
2022-12-14 12:58 UTC, Martin Cermak
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Cermak 2022-11-09 14:00:34 UTC
The new 5.14.0-186.kpq1.el9 seems to be missing kernel.function("__set_page_dirty_buffers").  Suspectedly the following kernel commit is related:

commit e621900ad28b748e058b81d6078a5d5eb37b3973
Author: Matthew Wilcox (Oracle) <willy@infradead.org>
Date:   Wed Feb 9 20:22:12 2022 +0000

    fs: Convert __set_page_dirty_buffers to block_dirty_folio
    
    Convert all callers; mostly this is just changing the aops to point
    at it, but a few implementations need a little more work.
    
    Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
    Tested-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
    Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
    Tested-by: Mike Marshall <hubcap@omnibond.com> # orangefs
    Tested-by: David Howells <dhowells@redhat.com> # afs


Reproducer:
# stap -P -w -p4 /root/systemtap/testsuite/buildok/vfs-all-probes.stp
semantic error: while resolving probe point: identifier 'kernel' at /usr/local/share/systemtap/tapset/linux/vfs.stp:825:38
        source: probe vfs.__set_page_dirty_buffers = kernel.function("__set_page_dirty_buffers")
                                                     ^

semantic error: no match (similar functions: __set_page_dirty_nobuffers, write_dirty_buffer, __set_page_dirty, __sync_dirty_buffer, set_page_dirty_lock)

Pass 2: analysis failed.  [man error::pass2]
Number of similar error messages suppressed: 1.
Rerun with -v to see them.
#
Comment 1 Martin Cermak 2022-12-14 12:58:40 UTC
Created attachment 14518 [details]
possible patch

possible patch
Comment 2 Martin Cermak 2022-12-14 16:39:50 UTC
Fixed in commit 8f3498781413a710dc9e128f5a96891a6a18fc52