Bug 297 - [PATCH] Strange date format for Finnish (fi_FI)
Summary: [PATCH] Strange date format for Finnish (fi_FI)
Alias: None
Product: glibc
Classification: Unclassified
Component: localedata (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Petter Reinholdtsen
Depends on:
Reported: 2004-08-02 15:31 UTC by Lauri Nurmi
Modified: 2019-04-10 10:55 UTC (History)
2 users (show)

See Also:
Last reconfirmed:
fweimer: security-

Patch to fix date_fmt for fi_FI (338 bytes, patch)
2005-01-14 18:27 UTC, Petter Reinholdtsen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauri Nurmi 2004-08-02 15:31:12 UTC
One of the format strings for date in Finnish locale is currently:

%a %Bn %e. %H:%M:%S %Z %Y

This is not exactly wrong, but it is a very unusual format, which IMO can't be
used in this kind of context.

After discussing about this with a couple of people, we decided that the best
format would probably be:

%a %-d.%-m.%Y %T %z

I would like to see this being fixed.
Comment 1 Petter Reinholdtsen 2004-11-02 16:10:20 UTC
I asked for feedback for earlier contributors for the fi_FI locale, and got this

From: Tommi.Vainikainen@iki.fi
Subject: Re: Date format for Finnish fi_FI locale
To: Petter Reinholdtsen <pere@hungry.com>
Date: Sun, 31 Oct 2004 22:30:05 +0200

On 2004-10-31T17:45:08+0200, pere@hungry.com wrote:
> You get this email because you contributed to the glibc locale for
> Finnish in the past. Recently, a change request for the fi_FI locale
> was submitted to the glibc bugzilla,
> <URL:http://sources.redhat.com/bugzilla/show_bug.cgi?id=297>.

I didn't bother to register to Bugzilla, but after reading this
Bugzilla report, I can confirm that it looks good, a much better
format for dates than what is currently used.

Tommi Vainikainen
Comment 2 Lars Wirzenius 2004-11-03 10:08:12 UTC
I agree with this format. '%a %Bn %e. %H:%M:%S %Z %Y' is quite unusual for
Finnish and though it is possible to read it correctly it requires more effort
than the proposed '%a %-d.%-m.%Y %T %z'

For any Finnish people who might want to chime in but would like examples:

original: ke marraskuun  3. 12:01:26 EET 2004
proposed: ke 3.11.2004 12:01:45 +0200
Comment 3 Petter Reinholdtsen 2005-01-14 18:27:29 UTC
Created attachment 367 [details]
Patch to fix date_fmt for fi_FI

If I understand correctly, you want to change date_fmt for fi_FI like

--- fi_FI	31 Oct 2004 23:42:26 -0000	1.18
+++ fi_FI	14 Jan 2005 18:24:50 -0000
@@ -2188,9 +2188,8 @@ d_fmt    "%d.%<U
 t_fmt	  "%T"
 am_pm	  "";""
 t_fmt_ampm  ""
-date_fmt	"%a %Bn %/
-e. %H:%M:%/
-S %Z %Y"
+date_fmt	"%a %-d.%\
+-m.%Y %T %z"
 first_weekday 2 % Monday
 first_workday 2 % Monday

The attached patch will do this change.
Comment 4 Petter Reinholdtsen 2005-01-14 18:29:45 UTC
Obs.  I just noticed.  The trailing \ should be changed to / in
the patch.
Comment 5 Lauri Nurmi 2005-01-29 10:41:05 UTC
Yes, looks good.
Comment 6 Ulrich Drepper 2005-10-15 04:08:16 UTC
Applied to CVS trunk.