Bug 28586 - Make distclean doesn't clean config.cache for gdbserver
Summary: Make distclean doesn't clean config.cache for gdbserver
Status: RESOLVED FIXED
Alias: None
Product: gdb
Classification: Unclassified
Component: gdb (show other bugs)
Version: HEAD
: P2 minor
Target Milestone: 12.1
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-11 19:45 UTC by Thomson
Modified: 2021-11-16 16:14 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
Project(s) to access:
ssh public key:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomson 2021-11-11 19:45:04 UTC 
In the line ~414 in gdbserver/Makefile.in which defines distclean targets, etc. Makefile was duplicated for removal, and config.cache is not in the list which makes the distclean not complete, and could confuse folloing configure run.

maintainer-clean realclean distclean: clean
	rm -f Makefile config.status config.h stamp-h config.log
	rm -f Makefile
Comment 1 Sourceware Commits 2021-11-16 16:13:43 UTC 
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b7c9d393d60957b901418359d2cf5d276bcc5e4b

commit b7c9d393d60957b901418359d2cf5d276bcc5e4b
Author: Tom Tromey <tromey@adacore.com>
Date:   Tue Nov 16 09:11:41 2021 -0700

    Remove config.cache in gdbserver's "distclean"
    
    PR gdb/28586 points out that "make distclean" fails to delete
    config.cache from gdbserver/.  This patch fixes the bug, and removes a
    duplicate "Makefile" deletion that was also pointed out in the PR.
Comment 2 Tom Tromey 2021-11-16 16:14:05 UTC 
Thanks for the report.  This is fixed now.