Bug 27421 - Improve DW_FORM_implicit_const handling in checksum_die/die_eq_1
Summary: Improve DW_FORM_implicit_const handling in checksum_die/die_eq_1
Status: NEW
Alias: None
Product: dwz
Classification: Unclassified
Component: default (show other bugs)
Version: unspecified
: P2 enhancement
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-15 12:53 UTC by Tom de Vries
Modified: 2021-03-02 07:52 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom de Vries 2021-02-15 12:53:17 UTC 
In commit 4100572 "Handle DW_FORM_implicit_const for DW_AT_decl_line", I added code to ensure that for an attribute DW_AT_decl_line, same-valued DW_FORM_implicit_const and DW_FORM_data1 are hashed equally in checksum_die, and found to be equal in die_eq_1.

It would be good to cover this for more attributes.  This was discussed on the ml here:
- https://sourceware.org/pipermail/dwz/2021q1/000872.html
- https://sourceware.org/pipermail/dwz/2021q1/000873.html