Bug 25513 - Update Makefiles; add Makefile for Darwin
Summary: Update Makefiles; add Makefile for Darwin
Status: UNCONFIRMED
Alias: None
Product: bzip2
Classification: Unclassified
Component: bzip2 (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-06 03:49 UTC by Jeffrey Walton
Modified: 2020-02-06 19:02 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments
Update Bzip2 makefiles for static archive and shared object. New makefile for Darwin dylib (8.17 KB, application/zip)
2020-02-06 03:49 UTC, Jeffrey Walton
Details
Update Bzip2 makefiles for static archive and shared object. New makefile for Darwin dylib (8.18 KB, application/zip)
2020-02-06 08:47 UTC, Jeffrey Walton
Details
Update Bzip2 makefiles for static archive and shared object. New makefile for Darwin dylib (8.15 KB, application/zip)
2020-02-06 18:08 UTC, Jeffrey Walton
Details
Update Bzip2 makefiles for static archive and shared object. New makefile for Darwin dylib (8.13 KB, application/zip)
2020-02-06 18:26 UTC, Jeffrey Walton
Details
Update Bzip2 makefiles for static archive and shared object. New makefile for Darwin dylib (8.18 KB, application/zip)
2020-02-06 19:02 UTC, Jeffrey Walton
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeffrey Walton 2020-02-06 03:49:35 UTC
Created attachment 12263 [details]
Update Bzip2 makefiles for static archive and shared object. New makefile for Darwin dylib

As [not] discussed on the mailing list :) There were no comments.

On Darwin the install_name libbz2.1.0.dylib was used.

---------- Forwarded message ---------
From: Jeffrey Walton <noloader@gmail.com>
Date: Sun, Feb 2, 2020 at 9:39 AM
Subject: Makefile for Darwin
To: <bzip2-devel@sourceware.org>

Hi Everyone,

Attached is a makefile for Darwin dylibs. The Darwin makefile is a lot
like the shared object makefile, so there is not much to explain. (In
fact, it was mostly a copy/paste). The Darwin makefile also sets
install_names before and after install. The makefile was tested on
modern OS X10.9 (x86_64 with clang) and OS X 10.5 (PowerMac with gcc).

The regular makefile and the shared object makefile are also included.
The makefiles were cleaned up to follow GNU Coding Standards. The
interesting sections of the manual are at [1][2][3].

Effectively it means standard variables were used so (1) the makefile
behaves like users expect, and (2) it is easier to for user's to
override default settings. For example, VPATHs are now supported by
using $< and $@ instead of hardcoding filenames.

Though the original makefiles were modified, all existing behavior is
preserved. Someone running 'make && make install' should see the same
behavior as before.

The open question (for me) on Darwin is, should the library use the
name libbz2.1.0.8.dylib. The name is consistent with Linux and Unix,
but I believe OS X typical uses Maj.Min numbers for this case, not
Maj.Min.Rev. That is, on OS X, libbz2.1.0.dylib would be more common.

If anyone has comments, then they would be appreciated.

I'll open a bug report with a pull request after comments. Or, if
Julian or Mark prefers, unzip in the bzip2 directory and simply check
them in. I don't care about credits or copyright or license.
Everything belongs to the project.

[1] https://www.gnu.org/prep/standards/html_node/Makefile-Basics.html
[2] https://www.gnu.org/prep/standards/html_node/Directory-Variables.html
[3] https://www.gnu.org/prep/standards/html_node/Command-Variables.html
Comment 1 Jeffrey Walton 2020-02-06 08:47:39 UTC
Created attachment 12264 [details]
Update Bzip2 makefiles for static archive and shared object. New makefile for Darwin dylib
Comment 2 Jeffrey Walton 2020-02-06 18:08:34 UTC
Created attachment 12266 [details]
Update Bzip2 makefiles for static archive and shared object. New makefile for Darwin dylib
Comment 3 Jeffrey Walton 2020-02-06 18:26:13 UTC
Created attachment 12267 [details]
Update Bzip2 makefiles for static archive and shared object. New makefile for Darwin dylib
Comment 4 Jeffrey Walton 2020-02-06 19:02:24 UTC
Created attachment 12268 [details]
Update Bzip2 makefiles for static archive and shared object. New makefile for Darwin dylib