Bug 24867 - Unintended malloc_info formatting changes
Summary: Unintended malloc_info formatting changes
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: malloc (show other bugs)
Version: 2.31
: P2 normal
Target Milestone: 2.31
Assignee: Florian Weimer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-01 11:21 UTC by Florian Weimer
Modified: 2019-11-18 17:58 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Weimer 2019-08-01 11:21:02 UTC
Various commits changed the \ escaping, introducing unwanted leading space, like this;

-       fprintf (fp, "\
+        fprintf (fp, "                                                       \

It looks like this happened in these two commits:

commit 987c02692a88b8c9024cb99187434aad02c3c047
Author: Ondřej Bílka <neleai@seznam.cz>
Date:   Fri May 30 13:24:56 2014 +0200

    Remove mi_arena nested function.

commit 6c8dbf00f536d78b1937b5af6f57be47fd376344
Author: Ondřej Bílka <neleai@seznam.cz>
Date:   Thu Jan 2 09:38:18 2014 +0100

    Reformat malloc to gnu style.
Comment 1 Sourceware Commits 2019-08-01 12:07:56 UTC
The master branch has been updated by Florian Weimer <fw@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b0f6679bcd738ea244a14acd879d974901e56c8e

commit b0f6679bcd738ea244a14acd879d974901e56c8e
Author: Florian Weimer <fweimer@redhat.com>
Date:   Thu Aug 1 14:06:24 2019 +0200

    malloc: Remove unwanted leading whitespace in malloc_info [BZ #24867]
    
    It was introduced in commit 6c8dbf00f536d78b1937b5af6f57be47fd376344
    ("Reformat malloc to gnu style.").
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Comment 2 Florian Weimer 2019-08-01 12:09:41 UTC
Fixed for glibc 2.31.
Comment 3 Sourceware Commits 2019-08-01 16:13:38 UTC
The release/2.30/master branch has been updated by Florian Weimer <fw@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=be9a328c93834648e0bec106a1f86357d1a8c7e1

commit be9a328c93834648e0bec106a1f86357d1a8c7e1
Author: Florian Weimer <fweimer@redhat.com>
Date:   Thu Aug 1 16:48:12 2019 +0200

    malloc: Remove unwanted leading whitespace in malloc_info [BZ #24867]
    
    It was introduced in commit 6c8dbf00f536d78b1937b5af6f57be47fd376344
    ("Reformat malloc to gnu style.").
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>
    (cherry picked from commit b0f6679bcd738ea244a14acd879d974901e56c8e)
Comment 4 Sourceware Commits 2019-10-30 18:52:18 UTC
The release/2.28/master branch has been updated by Arjun Shankar <arjun@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6d750b18999b52ec74102c046cd27181f943bda8

commit 6d750b18999b52ec74102c046cd27181f943bda8
Author: Florian Weimer <fweimer@redhat.com>
Date:   Thu Aug 1 14:06:24 2019 +0200

    malloc: Remove unwanted leading whitespace in malloc_info [BZ #24867]
    
    It was introduced in commit 6c8dbf00f536d78b1937b5af6f57be47fd376344
    ("Reformat malloc to gnu style.").
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>
    (cherry picked from commit b0f6679bcd738ea244a14acd879d974901e56c8e)
Comment 5 Sourceware Commits 2019-11-18 17:58:50 UTC
The release/2.29/master branch has been updated by Arjun Shankar <arjun@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a0a551d2590c43635a45a494ea3b972c7b91e79f

commit a0a551d2590c43635a45a494ea3b972c7b91e79f
Author: Florian Weimer <fweimer@redhat.com>
Date:   Thu Aug 1 14:06:24 2019 +0200

    malloc: Remove unwanted leading whitespace in malloc_info [BZ #24867]
    
    It was introduced in commit 6c8dbf00f536d78b1937b5af6f57be47fd376344
    ("Reformat malloc to gnu style.").
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>
    (cherry picked from commit b0f6679bcd738ea244a14acd879d974901e56c8e)