Created attachment 11913 [details]
Patch for getentropy test

Good evening.

While reading the source code, I've realized that one test meant to detect a defect in the getentropy() function always succeeds by accident.

This happens because of an incorrect use of parentheses at the following line in the current master branch:

  tst-getrandom.c:192:  if (memcmp (buf, buf2, sizeof (buf) == 0))

This comparison always evaluates to true and the original intent was obviously to compare the result of memcmp(...) to 0.

This test was added in 2016 in the following commit:

    commit 92dcaa3e2f7bf0f7f1c04cd2fb6a317df1a4e225
    Author: Florian Weimer <fweimer@redhat.com>
    Date:   Mon Dec 12 17:28:03 2016 +0100

    Add getentropy, getrandom, <sys/random.h> [BZ #17252]

I'm attaching a patch fixing this test.

Kind regards,
Olivier