Bug 23744 - regex refactorings to remove BE, avoid duplication
Summary: regex refactorings to remove BE, avoid duplication
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: regex (show other bugs)
Version: 2.28
: P2 minor
Target Milestone: 2.29
Assignee: eggert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-07 22:39 UTC by eggert
Modified: 2018-10-18 11:50 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-

Attachments
Replace BE/__builtin_expect with __glibc_likely and __glibc_unlikely (23.52 KB, patch)
2018-10-07 22:39 UTC, eggert 		Details | Diff
simplify by using intprops.h (1.02 KB, patch)
2018-10-07 22:40 UTC, eggert 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description eggert 2018-10-07 22:39:13 UTC 
Created attachment 11294 [details]
Replace BE/__builtin_expect with __glibc_likely and __glibc_unlikely

I'll attach two patches that do not change regex behavior, just make it easier to maintain. The first replaces uses of the BE macro (short for __builtin_expect) with the current style __glibc_likely and __glibc_unlikely. The second avoids code duplication with intprops.h.
Comment 1 eggert 2018-10-07 22:40:27 UTC 
Created attachment 11295 [details]
simplify by using intprops.h
Comment 2 eggert 2018-10-15 04:42:58 UTC 
I installed the patches and am marking this report as fixed.