The bpf syscall needs tapset support and test coverage. Syscall seccomp needs test coverage.
Created attachment 8386 [details]
In general the patch looks fine to me. However, I'm not sure about this change:
- uargs = user_string_quoted($uargs)
+ uargs = $uargs
I think you are on the right path here, that is an address, not a string. However, I think you should go a bit farther, deprecate the old string usage and rename the convenience variable to 'uargs_uaddr' to make sure users know this is a user address. The code would look something like:
%( systemtap_v <= "2.8" %?
uargs = user_string_quoted($uargs)
uargs_uaddr = $uargs
You would also need to make changes when printing the argstr (using the new variable name) and update the corresponding nd_syscall code.
Fixed in commit a7396f637e7c0c9083281b562d514506c465fc02