Bug 1766 - frysk.proc.task*.*.added|deleted replication
Summary: frysk.proc.task*.*.added|deleted replication
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P1 normal
Target Milestone: ---
Assignee: Andrew Cagney
URL:
Keywords:
Depends on:
Blocks: 1582
  Show dependency tree / graph
 
Reported: 2005-10-30 16:40 UTC by Andrew Cagney
Modified: 2005-10-30 17:24 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Cagney 2005-10-30 16:40:21 UTC 
Many tests have their own local but identical implementation of
Observer.added(Throwable) and Observer.deleted().

Refactor TaskObserverBase into:
- TaskSet (not everything needs it)
- TaskObserverBase
- AutoAddTaskObserverBase
Comment 1 Andrew Cagney 2005-10-30 16:44:39 UTC 
Index: frysk-core/frysk/proc/ChangeLog
2005-10-30  Andrew Cagney  <cagney@redhat.com>

        * TestLib.java: Split out .TaskSet from .TaskObserverBase.
        * TestTaskObserver.java, TestTaskForkedObserver.java,
        TestTaskClonedObserver.java: Update, add explict TaskSet.
Comment 2 Andrew Cagney 2005-10-30 17:06:08 UTC 
Index: frysk-core/frysk/proc/ChangeLog
2005-10-30  Andrew Cagney  <cagney@redhat.com>

        * TestLib.java: Split .TaskObserverBase, creating
        .AutoAddTaskObserverBase sub-class.  Use AutoAddTaskObserverBase
        throughout.
        * TestUnpaused.java, TestTaskTerminateObserver.java,
        TestTaskObserver.java, TestTaskForkedObserver.java,
        TestTaskClonedObserver.java, TestStop.java, TestStopAndStop.java,
        TestStopAndGo.java, TestStep.java, TestPaused.java,
        TestGoAndGo.java: Ditto.
Comment 3 Andrew Cagney 2005-10-30 17:23:27 UTC 
Index: frysk-core/frysk/proc/ChangeLog
2005-10-30  Andrew Cagney  <cagney@redhat.com>

        * TestLib.java: Fix tipo, TaskObserverBase, not TaskObserverBaseX.
        * TestProcGet.java: Reimplement CaptureAuxv by extending TestLib
        .AutoAddTaskObserverBase.
        * TestUnpaused.java: For TaskObserver's extend TaskObserverBase.
        * TestSyscallOpen.java: Ditto.
        * TestSyscall.java: Ditto.
        * TestSyscall2.java: Ditto.
        * TestStep.java: Ditto.
        * TestModify.java: Ditto.
        * TestI386Regs.java: Ditto.
        * TestI386Modify.java: Ditto.
Comment 4 Andrew Cagney 2005-10-30 17:24:24 UTC 
refactored.