Bug 13950 - Properly comment out FIXME entries for bo_CN and bo_IN
Summary: Properly comment out FIXME entries for bo_CN and bo_IN
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: localedata (show other bugs)
Version: 2.15
: P2 normal
Target Milestone: ---
Assignee: Andreas Jaeger
URL:
Keywords:
Depends on:
Blocks: 13237
  Show dependency treegraph
 
Reported: 2012-04-06 03:40 UTC by Chris Leonard
Modified: 2014-06-25 11:21 UTC (History)
3 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-


Attachments
add commenting notation (%) to FIXME entries (590 bytes, patch)
2012-04-06 03:40 UTC, Chris Leonard
Details | Diff
bo_IN-and-bo_CN-patch-ver2 (773 bytes, patch)
2012-11-15 00:59 UTC, Chris Leonard
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Leonard 2012-04-06 03:40:22 UTC
Created attachment 6321 [details]
add commenting notation (%) to FIXME entries

Patch attached.

No maintainer listed in locale, should be non-controversial change.


This is one of a number of such country-name corrections first identified in:
http://sourceware.org/bugzilla/show_bug.cgi?id=13237
Comment 1 Chris Leonard 2012-06-27 04:28:57 UTC
Can someone please land this patch?

Does anyone really have any doubts about the correctness of NOT displaying FIXME as the countryname?
Comment 2 Siddhesh Poyarekar 2012-10-23 12:39:25 UTC
Patches are not reviewed in the bugzilla.  To get your patches reviewed, please post them to libc-alpha mailing list using the following guidelines:

http://sourceware.org/glibc/wiki/Contribution%20checklist
Comment 3 Chris Leonard 2012-10-23 14:04:59 UTC
The Contribution checklist suggests that locale bugs should go to the libc-locales list.  It does not specify that all bugs should go to libc-alpha.  Is that truly the case?  If so, then that should be clarified on the Contributionss page.

This bug was reported to libc-locales at the time it was filed.  Does no one review those posts?

http://sourceware.org/ml/libc-locales/2012-q2/msg00042.html

TIA for your help in understanding and clarifying your patch reviewing process.
Comment 4 Siddhesh Poyarekar 2012-10-23 14:16:24 UTC
(In reply to comment #3)
> The Contribution checklist suggests that locale bugs should go to the
> libc-locales list.  It does not specify that all bugs should go to libc-alpha. 
> Is that truly the case?  If so, then that should be clarified on the
> Contributionss page.

I don't know if anyone looks there, but you could send it to libc-locales and cc libc-alpha.
 
> This bug was reported to libc-locales at the time it was filed.  Does no one
> review those posts?

Definitely not patches in bug reports, since it's more convenient to discuss patches directly than when they're just a hyperlink on the list.  I don't know who usually reviews localedata patches; I merely wandered into this space while my code was compiling ;)
Comment 5 Chris Leonard 2012-11-15 00:59:03 UTC
Created attachment 6737 [details]
bo_IN-and-bo_CN-patch-ver2

Replacing previous patch based on libc-alpha discussion.

Start of thread

http://sourceware.org/ml/libc-alpha/2012-11/msg00306.html
Comment 6 Andreas Jaeger 2012-11-15 08:23:00 UTC
Fixed now, thanks for the patch:

commit 2663b74f8103a2a8a46b4896439b7a452480fc7c
Author: Chris Leonard <cjlhomeaddress@gmail.com>
Date:   Thu Nov 15 09:20:20 2012 +0100

    2012-11-15  Chris Leonard  <cjlhomeaddress@gmail.com>
    
        [BZ #13950]
        * locales/bo_CN (LC_NAME, LC_ADDRESS): Remove some FIXMEs with
        proper content, disable others.
        * locales/bo_IN (LC_NAME, LC_ADDRESS): Likewise.