Bug 13455 - tapset/nd_syscalls2.stp:# FIXME: should prefer sys_signalfd4
Summary: tapset/nd_syscalls2.stp:# FIXME: should prefer sys_signalfd4
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: tapsets (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on: 11424
Blocks:
  Show dependency tree / graph
 
Reported: 2011-11-29 19:25 UTC by Mark Wielaard
Modified: 2012-07-23 19:24 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
Project(s) to access:
ssh public key:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Wielaard 2011-11-29 19:25:49 UTC 
The corresponding tapset/syscalls2.stp has:

probe syscall.signalfd = kernel.function("sys_signalfd4").call !,
                         kernel.function("sys_signalfd").call ?
Comment 1 David Smith 2011-11-30 18:40:38 UTC 
The reason why it is done this way in syscalls.stp is that in the kernel
sys_signalfd is just a wrapper around sys_signalfd4.  This way we
ignore the sys_signalfd call, and only catch the sys_signalfd4 call on
kernels with sys_signalfd4.

Unfortunately, as bug #11424 notes, '!' (optional and sufficient) doesn't work
for kprobe.function probes.  So, the above logic will be difficult to duplicate
in tapset/nd_syscalls.stp.
Comment 2 David Smith 2012-07-23 19:24:24 UTC 
Now that bug #11424 and bug #14378 are fixed, this bug can be addressed.

Fixed in commit 1c3d0f1.