Bug 13453 - tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_inotify_init1()
Summary: tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_inotify_init1()
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: tapsets (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on: 11424
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-29 19:20 UTC by Mark Wielaard
Modified: 2012-07-20 20:47 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Wielaard 2011-11-29 19:20:33 UTC
The corresponding syscalls.stp has:

probe syscall.inotify_init = kernel.function("sys_inotify_init1").call !,
                             kernel.function("sys_inotify_init").call ?
Comment 1 David Smith 2011-11-30 17:13:22 UTC
The reason why it is done this way in syscalls.stp is that in the kernel sys_inotify_init is just a wrapper around sys_inotify_init1.  This way we ignore the sys_inotify_init call, and only catch the sys_inotify_init1 call on kernels with sys_inotify_init1.

Unfortunately, as bug #11424 notes, '!' (optional and sufficient) doesn't work
for kprobe.function probes.  So, the above logic will be difficult to duplicate
in tapset/nd_syscalls.stp.
Comment 2 David Smith 2012-07-20 20:47:14 UTC
Now that bug #11424 and bug #14378 are fixed, this bug can be addressed.

Fixed in commit 42f9c99.