Bug 1102 - pedantic warnings in pthreads headers
Summary: pedantic warnings in pthreads headers
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: nptl (show other bugs)
Version: 2.3.5
: P2 normal
Target Milestone: ---
Assignee: Roland McGrath
URL:
Keywords:
Depends on:
Blocks: libc236
  Show dependency treegraph
 
Reported: 2005-07-18 03:18 UTC by Roland McGrath
Modified: 2005-07-19 03:30 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roland McGrath 2005-07-18 03:18:57 UTC
This trunk patch should go into the 2.3 branch:

2005-07-11  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/pthread/pthread.h (PTHREAD_MUTEX_INITIALIZER,
	PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP,
	PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP,
	PTHREAD_MUTEX_ADAPTIVE_NP, PTHREAD_RWLOCK_INITIALIZER,
	PTHREAD_RWLOCK_WRITER_NONRECURSIVE_INITIALIZER_NP,
	PTHREAD_COND_INITIALIZER): Supply zeros for all fields
	in the structure.
	* Makefile (tests): Add tst-initializers1.
	(CFLAGS-tst-initializers1.c): Set.
	* tst-initializers1.c: New test.
Comment 1 Sourceware Commits 2005-07-18 03:20:13 UTC
Subject: Bug 1102

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-07-18 03:20:10

Modified files:
	nptl           : Makefile 

Log message:
	2005-07-11  Jakub Jelinek  <jakub@redhat.com>
	
	[BZ #1102]
	* sysdeps/pthread/pthread.h (PTHREAD_MUTEX_INITIALIZER,
	PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP,
	PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP,
	PTHREAD_MUTEX_ADAPTIVE_NP, PTHREAD_RWLOCK_INITIALIZER,
	PTHREAD_RWLOCK_WRITER_NONRECURSIVE_INITIALIZER_NP,
	PTHREAD_COND_INITIALIZER): Supply zeros for all fields
	in the structure.
	* Makefile (tests): Add tst-initializers1.
	(CFLAGS-tst-initializers1.c): Set.
	* tst-initializers1.c: New test.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/nptl/Makefile.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.165.2.1&r2=1.165.2.2

Comment 2 Sourceware Commits 2005-07-18 03:20:18 UTC
Subject: Bug 1102

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-07-18 03:20:13

Modified files:
	nptl/sysdeps/pthread: pthread.h 

Log message:
	2005-07-11  Jakub Jelinek  <jakub@redhat.com>
	
	[BZ #1102]
	* sysdeps/pthread/pthread.h (PTHREAD_MUTEX_INITIALIZER,
	PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP,
	PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP,
	PTHREAD_MUTEX_ADAPTIVE_NP, PTHREAD_RWLOCK_INITIALIZER,
	PTHREAD_RWLOCK_WRITER_NONRECURSIVE_INITIALIZER_NP,
	PTHREAD_COND_INITIALIZER): Supply zeros for all fields
	in the structure.
	* Makefile (tests): Add tst-initializers1.
	(CFLAGS-tst-initializers1.c): Set.
	* tst-initializers1.c: New test.
	2005-05-03  Ulrich Drepper  <drepper@redhat.com>
	
	[BZ #915]
	* sysdeps/pthread/pthread.h: Avoid empty initializers.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/nptl/sysdeps/pthread/pthread.h.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.30.2.1&r2=1.30.2.2

Comment 3 Sourceware Commits 2005-07-18 03:22:03 UTC
Subject: Bug 1102

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-07-18 03:21:59

Modified files:
	nptl/sysdeps/pthread: pthread.h 
	nptl/sysdeps/pthread/bits: libc-lock.h 

Log message:
	2005-04-05  Jakub Jelinek  <jakub@redhat.com>
	
	[BZ #1102]
	* sysdeps/pthread/pthread.h (__pthread_cleanup_routine): Use
	__inline instead of inline.
	* sysdeps/pthread/bits/libc-lock.h (__libc_cleanup_routine): Likewise.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/nptl/sysdeps/pthread/pthread.h.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.30.2.2&r2=1.30.2.3
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/nptl/sysdeps/pthread/bits/libc-lock.h.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.17.4.1&r2=1.17.4.2

Comment 4 Sourceware Commits 2005-07-18 03:27:25 UTC
Subject: Bug 1102

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-07-18 03:27:21

Added files:
	nptl           : tst-initializers1.c 

Log message:
	2005-07-11  Jakub Jelinek  <jakub@redhat.com>
	
	[BZ #1102]
	* sysdeps/pthread/pthread.h (PTHREAD_MUTEX_INITIALIZER,
	PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP,
	PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP,
	PTHREAD_MUTEX_ADAPTIVE_NP, PTHREAD_RWLOCK_INITIALIZER,
	PTHREAD_RWLOCK_WRITER_NONRECURSIVE_INITIALIZER_NP,
	PTHREAD_COND_INITIALIZER): Supply zeros for all fields
	in the structure.
	* Makefile (tests): Add tst-initializers1.
	(CFLAGS-tst-initializers1.c): Set.
	* tst-initializers1.c: New test.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/nptl/tst-initializers1.c.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=NONE&r2=1.1.2.1

Comment 5 Roland McGrath 2005-07-19 03:30:32 UTC
This fix is now in the 2.3 branch as well as the trunk, and the problem should
be resolved as of the 2.3.6 release.