Bug 10764 - compiler option added after operands
Summary: compiler option added after operands
Status: RESOLVED FIXED
Alias: None
Product: binutils
Classification: Unclassified
Component: binutils (show other bugs)
Version: 2.21
: P2 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-13 10:50 UTC by Jerker Bäck
Modified: 2009-10-16 14:09 UTC (History)
1 user (show)

See Also:
Host: x86_64-unknown-interix6.1
Target: x86_64-unknown-interix6.1
Build: x86_64-unknown-interix6.1
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jerker Bäck 2009-10-13 10:50:33 UTC
The compiler option -Wno-error is added last, after the operand.
This is something my compiler isn't happy about

===================================================================
RCS file: /cvs/src/src/binutils/Makefile.am,v
retrieving revision 1.119
diff -w -b -B -u -p -r1.119 Makefile.am
--- Makefile.am	5 Sep 2009 11:09:34 -0000	1.119
+++ Makefile.am	13 Oct 2009 02:16:37 -0000
@@ -255,16 +255,16 @@ sysinfo$(EXEEXT_FOR_BUILD): sysinfo.o sy
 
 syslex.o: syslex.c sysinfo.h config.h
 	if [ -r syslex.c ]; then \
-	  $(CC_FOR_BUILD) -c -I. $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) syslex.c -Wno-error ; \
+	  $(CC_FOR_BUILD) -c -I. $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) -Wno-error syslex.c ; \
 	else \
-	  $(CC_FOR_BUILD) -c -I. -I$(srcdir) $(AM_CFLAGS) $(CFLAGS_FOR_BUILD)
$(srcdir)/syslex.c -Wno-error ;\
+	  $(CC_FOR_BUILD) -c -I. -I$(srcdir) $(AM_CFLAGS) $(CFLAGS_FOR_BUILD)
-Wno-error $(srcdir)/syslex.c ;\
 	fi
 
 sysinfo.o: sysinfo.c
 	if [ -r sysinfo.c ]; then \
-	  $(CC_FOR_BUILD) -c -I. $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) sysinfo.c -Wno-error ; \
+	  $(CC_FOR_BUILD) -c -I. $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) -Wno-error sysinfo.c ; \
 	else \
-	  $(CC_FOR_BUILD) -c -I. $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) $(srcdir)/sysinfo.c
-Wno-error ; \
+	  $(CC_FOR_BUILD) -c -I. $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) -Wno-error
$(srcdir)/sysinfo.c ; \
 	fi
Comment 1 cvs-commit@gcc.gnu.org 2009-10-16 14:09:13 UTC
Subject: Bug 10764

CVSROOT:	/cvs/src
Module name:	src
Changes by:	nickc@sourceware.org	2009-10-16 14:08:58

Modified files:
	binutils       : ChangeLog Makefile.am Makefile.in 

Log message:
	PR 10764
	* Makefile.am (sysinfo.o, syslex.o): Place source file after all
	command line switches.
	* Makefile.in: Regenerate.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/binutils/ChangeLog.diff?cvsroot=src&r1=1.1547&r2=1.1548
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/binutils/Makefile.am.diff?cvsroot=src&r1=1.119&r2=1.120
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/binutils/Makefile.in.diff?cvsroot=src&r1=1.140&r2=1.141

Comment 2 Nick Clifton 2009-10-16 14:09:51 UTC
Hi Jerker,

  Thanks for reporting this problem and for providing a patch.  I have checked
it in along with the following changelog entry.

Cheers
  Nick

binutils/ChangeLog
2009-10-16  Jerker Bäck <jerker.back@gmail.com>

	PR 10764
	* Makefile.am (sysinfo.o, syslex.o): Place source file after all
	command line switches.
	* Makefile.in: Regenerate.
Comment 3 cvs-commit@gcc.gnu.org 2010-01-05 01:52:59 UTC
Subject: Bug 10764

CVSROOT:	/cvs/src
Module name:	src
Branch: 	binutils-2_20-branch
Changes by:	amodra@sourceware.org	2010-01-05 01:52:42

Modified files:
	binutils       : ChangeLog Makefile.am Makefile.in 

Log message:
	PR 11129
	2009-11-20  Ben Elliston  <bje@au.ibm.com>
	* Makefile.am (syslex.o): Use $(NO_WERROR) not -Wno-error.
	(sysinfo.o): Likewise.
	PR 10764
	2009-10-16  Jerker Bäck <jerker.back@gmail.com>
	* Makefile.am (sysinfo.o, syslex.o): Place source file after all
	command line switches.
	* Makefile.in: Regenerate.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/binutils/ChangeLog.diff?cvsroot=src&only_with_tag=binutils-2_20-branch&r1=1.1521.2.17&r2=1.1521.2.18
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/binutils/Makefile.am.diff?cvsroot=src&only_with_tag=binutils-2_20-branch&r1=1.118.2.1&r2=1.118.2.2
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/binutils/Makefile.in.diff?cvsroot=src&only_with_tag=binutils-2_20-branch&r1=1.139.2.1&r2=1.139.2.2