Summary: | ld-gc testsuite errors on cygwin | ||
---|---|---|---|
Product: | binutils | Reporter: | Christian Joensson <christian.joensson> |
Component: | ld | Assignee: | unassigned |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bug-binutils, dave.korn.cygwin |
Priority: | P2 | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Host: | i686-pc-cygwin | Target: | i686-pc-cygwin |
Build: | i686-pc-cygwin | Last reconfirmed: | |
Attachments: | Do not assume that garbage collection is available on cygwin targets. |
Description
Christian Joensson
2009-03-23 12:46:41 UTC
GC is only implemented OOTB for Elf targets, and also apparently for XCOFF, from where it might be possible to backport the support to plain COFF and PE. Created attachment 3859 [details]
Do not assume that garbage collection is available on cygwin targets.
Hi Christian, Since garbage collection is not currently implemented for Cygwin toolchains the linker testsuite ought to skip the gc tests for this target. So please could you try out the uploaded patch to update the check_gc_sections_available procedure in the linker test library. Cheers Nick Hi Nick, === ld tests === @@ -343,10 +343,6 @@ Running /usr/build/src-binutils/ld/tests Running /usr/build/src-binutils/ld/testsuite/ld-frv/frv-elf.exp ... Running /usr/build/src-binutils/ld/testsuite/ld-frv/tls.exp ... Running /usr/build/src-binutils/ld/testsuite/ld-gc/gc.exp ... -FAIL: Check --gc-section -FAIL: Check --gc-section/-q -FAIL: Check --gc-section/-r/-e -FAIL: Check --gc-section/-r/-u Running /usr/build/src-binutils/ld/testsuite/ld-h8300/h8300.exp ... Running /usr/build/src-binutils/ld/testsuite/ld-i386/i386.exp ... Running /usr/build/src-binutils/ld/testsuite/ld-ia64/ia64.exp ... @@ -426,8 +422,8 @@ Running /usr/build/src-binutils/ld/tests === ld Summary === -# of expected passes 77 -# of unexpected failures 6 +# of expected passes 76 +# of unexpected failures 2 # of expected failures 7 # of unsupported tests 2 /usr/build/obj-binutils/ld/ld-new 2.19.51.20090401 admin@ubik /usr/build/obj-binutils Your patch works fine, please commit it. The loss of one PASS is caused by the removal of the "--gc-sections -r without -e" test, which was emitting the appropriate error message even though gc would not have been performed even with the required -e (or -u) flag. Subject: Bug 9987 CVSROOT: /cvs/src Module name: src Changes by: nickc@sourceware.org 2009-04-02 09:34:22 Modified files: ld/testsuite : ChangeLog ld/testsuite/lib: ld-lib.exp Log message: PR 9987 * lib/ld-lib.exp (check_gc_sections_available): Do not run garbage collection tests for cygwin targets. Patches: http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/ld/testsuite/ChangeLog.diff?cvsroot=src&r1=1.1064&r2=1.1065 http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/ld/testsuite/lib/ld-lib.exp.diff?cvsroot=src&r1=1.61&r2=1.62 Hi Guys, OK - I have applied my patch. I will close this issue now since the problem - ld testsuite failures - has been addressed. The enhancement - supporting garbage collection in cygwin targeted toolchains - can be documented in this PR if/when it is ever implemented. Cheers Nick |