Summary: | en_GB locale has wrong week specifier | ||
---|---|---|---|
Product: | glibc | Reporter: | Petr Baudis <pasky> |
Component: | localedata | Assignee: | GNU C Library Locale Maintainers <libc-locales> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | aurelien, glibc-bugs, P, samuel.thibault |
Priority: | P2 | Flags: | fweimer:
security-
|
Version: | unspecified | ||
Target Milestone: | --- | ||
Host: | Target: | ||
Build: | Last reconfirmed: | ||
Attachments: |
Proposed patch
Easily test correctness of first weekday setting Easily test correctness of first weekday setting Easily test correctness of first weekday setting Fix first_weekday and week |
Description
Petr Baudis
2008-12-04 03:29:19 UTC
Created attachment 3089 [details]
Proposed patch
Test case? Sorry, I will be glad to provide one, but could you be more specific? Just a testcase testing whether en_GB returns the correct weekstart? That doesn't look very useful... Or something iterating all the SUPPORTED locales to check whether their weekstart is only Sunday or Monday? There seem to be no tests like that so far, but I'm not sure what else do you mean. Created attachment 3648 [details]
Easily test correctness of first weekday setting
Sorry, I was kind of dense I guess - you probably mean a way to reproduce and
verify the settings. I have attached a simple test application that interprets
the relevant locale data based on my current understanding of the relevant
specs. The two printed weekday names should match in correctly defined locale.
This update has now introduced another bug, whereby the start of the week is Tuesday, instead of Monday. The first weekday and first workday parameters should both be 1, instead of 2: first_weekday 1 first_workday 1 Created attachment 3797 [details]
Easily test correctness of first weekday setting
Here is an even better testcase: I have added what the firstday is in
english, to check that the translation is correct.
Created attachment 3798 [details]
Easily test correctness of first weekday setting
Oops, I hadn't seen that it was showing the first day of the week, not
the first day of the week system. Here is a fixed version (my concern
is to show the english name to make sure things are really correct).
Created attachment 3799 [details]
Fix first_weekday and week
Here is a patch that addresses the en_GB concern initially described
here as well as csb_PL and et_EE (same concern), and fixes week[2] into
always be 19971130, as glibc assumes this.
OK, I applied the patch. But if people complain I'll point to you. No problem, I'll take the time to explain them. *** Bug 9835 has been marked as a duplicate of this bug. *** |