Bug 5659

Summary: frysk.hpd.TestSysRoot contains package public variables
Product: frysk Reporter: Andrew Cagney <cagney>
Component: generalAssignee: Stan Cox <scox>
Severity: normal    
Priority: P2    
Version: unspecified   
Target Milestone: ---   
Host: Target:
Build: Last reconfirmed:
Bug Depends on:    
Bug Blocks: 5624    

Description Andrew Cagney 2008-01-22 03:55:18 UTC
For instance:

public class TestSysRoot extends TestLib {
  Expect expect;

when coding we try to make all fields as private as possible; as this way we
benefit from the compilers ability to identify no-longer-used code; if the code
isn't private then the check doesn't work.
Comment 1 Stan Cox 2008-01-30 15:08:53 UTC
Move installation of test-sysroot to pkglibdir.

* TestSysRoot.java (testHaveSysRoot): test-sysroot now lives in
pkglibdir.  Use sendCommandExpectPrompt.