| Summary: | iostat-scsi.stp instruments function removed in 2.6.24 kernel | ||
|---|---|---|---|
| Product: | systemtap | Reporter: | William Cohen <wcohen> |
| Component: | testsuite | Assignee: | Unassigned <systemtap> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ananth, dsmith |
| Priority: | P2 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Host: | Target: | ||
| Build: | Last reconfirmed: | ||
| Attachments: |
possible fix
Add -g to test script |
||
Created attachment 2124 [details]
possible fix
Here's a patch that attempts to fix this example for 2.6.24. Note that because
of the addition of the embedded C function, you have to add '-g' to the stap
command line.
The bug I'm commenting also affects iostat-scsi.stp behaviour on arm
architecture. iostat-scsi.stp fails with the following output:
$ stap -p4 iostat-scsi.stp 5 -vv
...
semantic error: no match while resolving probe point kernel.function("st_do_scsi")
David, Your patch in comment 2 does fix the problem. Can you please commit it? Bruno, I see that st_do_scsi has been around since 2005 and still exists as of today's Linus' git. Not sure why the symbol resolution failed. Created attachment 2305 [details]
Add -g to test script
David,
This is needed to "PASS" the test when running make check.
I've checked both patches in. |
The iostat-scsi.stp tests fails because the sd_init_command() function is removed from the most 2.6.24 kernel: $ ../../install/bin/stap -p4 ../../src/testsuite/../examples/iostat-scsi.stp 10 semantic error: no match while resolving probe point kernel.function("sd_init_command") Pass 2: analysis failed. Try again with more '-v' (verbose) options. The following URL documents the patch to driver/scsi/sd.c that causes the problem: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7f9a6bc4e9d59e7fcf03ed23f60cd81ca5d80b65