Bug 4896

Summary: Update elf/elf.h R_PARISC_* relocations.
Product: glibc Reporter: Carlos O'Donell <carlos>
Component: libcAssignee: Ulrich Drepper <drepper.fsp>
Status: RESOLVED FIXED    
Severity: enhancement CC: glibc-bugs
Priority: P2 Flags: fweimer: security-
Version: unspecified   
Target Milestone: ---   
Host: hppa-linux-gnu Target: hppa-linux-gnu
Build: hppa-linux-gnu Last reconfirmed:
Attachments: Update relocations for hppa-linux-gnu.

Description Carlos O'Donell 2007-08-04 17:52:00 UTC 
The file elf/elf.h needs updating for hppa-linux-gnu.
New PLABEL relocations need to be added to handle proper OPD in executables.
New TLS relocations are required for TLS and NPTL.

Patch attached to this issue.

Tested without regression on hppa-linux-gnu.

Please apply to head.
Comment 1 Carlos O'Donell 2007-08-04 17:53:28 UTC 
Created attachment 1946 [details]
Update relocations for hppa-linux-gnu.

This patch adds PLABEL, and TLS relocations for hppa-linux-gnu.
Comment 2 Carlos O'Donell 2007-08-04 17:56:30 UTC 
The PLABEL relocations are already part of the hppa-linux-gnu elf spec.

TeX file describing hppa-linux-gnu relocations for TLS.
http://cvs.parisc-linux.org/*checkout*/web/src/documentation/tls/hppa-tls-implementation.tex?content-type=text%2Fplain

Is there anything else needed to get these relocations upstream?
Comment 3 Ulrich Drepper 2007-08-21 14:16:56 UTC 
I added it despite your patch being deficient:

- never submit patches for the changelog.  It's really not that hard to get your
brain around this, the changelog changes too frequently for that

- you weren't using tag characters.  That's crucial in headers since it reduces
the size of the files

- the comments were incorrectly formatted

In short, almost every single line had at least one mistake.  Way to go.