Bug 4565

Summary: getTermwidth does not honor Terminal
Product: frysk Reporter: Stan Cox <scox>
Component: generalAssignee: Unassigned <frysk-bugzilla>
Status: SUSPENDED ---    
Severity: normal    
Priority: P2    
Version: unspecified   
Target Milestone: ---   
Host: Target:
Build: Last reconfirmed:
Bug Depends on:    
Bug Blocks: 4054    

Description Stan Cox 2007-05-29 22:13:12 UTC
http://sourceforge.net/tracker/index.php?func=detail&aid=1727930&group_id=64033&atid=506056

getTermwidth does not honor Terminal.  	 
A user specified terminal is not honored by getTermwidth and getTermheight.
e.g. Given:
ConsoleReader(new FileInputStream(java.io.FileDescriptor.in),
new PrintWriter(System.out),
null,
new PtyTerminal(frysk.sys.FileDescriptor.in))

getTermwidth calls
Terminal.setupTerminal ().getTerminalWidth ();
which results in calling UnixTerminal.getTerminalWidth.

        * src/jline/ConsoleReader.java (getTermwidth): Use terminal instead of
        Terminal.setupTerminal()
        (getTermheight): Likewise.
 
Index: frysk-imports/jline/src/jline/ConsoleReader.java
===================================================================
RCS file: /cvs/frysk/frysk-imports/jline/src/jline/ConsoleReader.java,v
retrieving revision 1.2
diff -u -p -r1.2 ConsoleReader.java
--- frysk-imports/jline/src/jline/ConsoleReader.java    19 Jul 2005 15:27:55
-0000      1.2
+++ frysk-imports/jline/src/jline/ConsoleReader.java    29 May 2007 18:38:44 -0000
@@ -352,7 +352,7 @@ public class ConsoleReader
         */
        public int getTermwidth ()
        {
-               return Terminal.setupTerminal ().getTerminalWidth ();
+               return terminal.getTerminalWidth ();
        }


@@ -365,7 +365,7 @@ public class ConsoleReader
         */
        public int getTermheight ()
        {
-               return Terminal.setupTerminal ().getTerminalHeight ();
+               return terminal.getTerminalHeight ();
        }