Bug 3729

Summary:	Vector is "old school"
Product:	frysk	Reporter:	Andrew Cagney <cagney>
Component:	general	Assignee:	Adam Jocksch <ajocksch>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	P2
Version:	unspecified
Target Milestone:	---
Host:		Target:
Build:		Last reconfirmed:
Bug Depends on:	3750
Bug Blocks:	3076

Description Andrew Cagney 2006-12-14 20:20:43 UTC

Some of the bindings code is using the 1.0 java.util.Vector object, it should be
using the more up-to-date 1.2 collections framework.

Comment 1 Adam Jocksch 2006-12-14 21:08:23 UTC

References of java.util.Vector have been removed from lib.dw.Dwfl and
lib.dw.TestDwfl and were replaced with java.util.List objects.

Comment 2 Andrew Cagney 2006-12-15 17:23:22 UTC

ChangeLog entries?
Can be closed?

Comment 3 Adam Jocksch 2006-12-16 20:48:22 UTC

I have gone through frysk.core and frysk.gui and refactored the code to use the
1.2 collections framework wherever possible. There are still a number of
references to Vector in cli.hpd, but I have not looked at those.

As far as the bindings/core/gui are concerned, this bug can be closed.

ChangeLog from my previous commit:
2006-12-14  Adam Jocksch  <ajocksch@redhat.com>

	* Dwfl.java (getLineAddresses): Fixed small bug in initializing list.

	* Dwfl.java (getLineAddresses): Now returns a list rather than a Vector
	(bug #3729).
	* TestDwfl.java (testGetAddresses): Refactored to reflect above change.

ChangeLog entries for this change:
frysk-core/frysk/dom:
2006-12-16  Adam Jocksch  <ajocksch@redhat.com>

	* DOMImage.java (getFunctions): Moved from using Vectors to using the
	collections framework.
	* DOMLine.java: Ditto.
	* DOMSource.java (getInlinedFunctions): Ditto.

frysk-gui/frysk/gui:
2006-12-16  Adam Jocksch  <ajocksch@redhat.com>

	* DebugHistory.java: Events are now kept using a LinkedList instead of
	a Vector.
	* SessionManagerGui.java (popupControl): Is now a LinkedList.

frysk-gui/frysk/gui/common:
2006-12-16  Adam Jocksch  <ajocksch@redhat.com>

	* prefs/BooleanPreference.java (listeners): Is now a LinkedList.
	* prefs/ColorPreference.java (listeners): Ditto.
	* prefs/IntPreference.java (listeners): Ditto.

frysk-gui/frysk/gui/monitor:
2006-12-16  Adam Jocksch  <ajocksch@redhat.com>

	* DetailedObserverTreeView (listObservers): Is now a LinkedList.
	* TrayIcon.java (popupWindows): Ditto.
	(setPopupWindows): Now uses Collections.copy.

frysk-gui/frysk/gui/srcwin:
2006-12-16  Adam Jocksch  <ajocksch@redhat.com>

	* CurrentStackView.java (observers): Is now a LinkedList.
	* View.java (getFunctions): Now returns a list.
	* MixedView.java (getFunctions): Ditto.
	* SourceView.java (getFunctions): Ditto.
	(refreshVars): Now takes and returns a List.
	* SourceBuffer.java (functions): Is now a LinkedList.
	(getFunctions): Now returns a List.
	* SourceWindow.java: Refactored to reflect above changes.
	* VariableWatchView.java (observers): Is now a LinkedList.
	(variables): Ditto.
	* prefs/SyntaxPreference.java (syntaxListeners): Ditto.
	* tags/Tagset.java (tags): Ditto.
	* tags/TagsetManager.java: Removed references to Vector.

Comment 4 Andrew Cagney 2006-12-18 15:56:29 UTC

The trick here is to create new bugs for the work remaining, and then close this
one for the work completed.

I created http://sourceware.org/bugzilla/show_bug.cgi?id=3750

I'd close this bug.

Comment 5 Stan Cox 2006-12-19 15:29:45 UTC

(3758 mentions a problem resulting from the #3 change)

Comment 6 Stan Cox 2006-12-19 15:31:16 UTC

*** Bug 3758 has been marked as a duplicate of this bug. ***

Comment 7 Adam Jocksch 2007-01-08 20:35:39 UTC

Closing Bug