Summary: | lket does not trace the right pid and appname | ||
---|---|---|---|
Product: | systemtap | Reporter: | Eugene Teo <eteo> |
Component: | lket | Assignee: | Eugene Teo <eteo> |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | ||
Priority: | P2 | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Host: | Target: | ||
Build: | Last reconfirmed: |
Description
Eugene Teo
2006-11-17 13:54:09 UTC
LKET will log only the tid for smaller trace data size and faster speed. But LKET will trace the fork event by default, so the relation between tid,pid,ppid could be figured out by looking at fork events. The problem is that, when lket-b2a record the relation of pid/appname, it does record pid and appname, but when at a later stage lket-b2a retrieve the appname for a process, it use tid instead of pid to search, and then it will return NULL. I will fix this in lket-b2a. Please keep in mind that "critical" bugs are meant to refer to showstoppers: ones that absolutely must be fixed ASAP because systems are down. This one does not seem to qualify. This patch should fix this problem. Index: tapset/LKET/Changelog =================================================================== RCS file: /cvs/systemtap/src/tapset/LKET/Changelog,v retrieving revision 1.33 diff -r1.33 Changelog 0a1,6 > 2007-11-18 Eugene Teo <eteo@redhat.com> > > PR 3536 > * lket_trace.stp: appNameTree is indexed by tgid and not > pid. See runtime/lket/b2a/lket_b2a.c (register_appname) > Index: tapset/LKET/lket_trace.stp =================================================================== RCS file: /cvs/systemtap/src/tapset/LKET/lket_trace.stp,v retrieving revision 1.10 diff -r1.10 lket_trace.stp 154c154 < (_FMT_)((int64_t)current->pid << 32 | \ --- > (_FMT_)((int64_t)current->tgid << 32 | \ 164c164 < (_FMT_)((int64_t)current->pid << 32 | \ --- > (_FMT_)((int64_t)current->tgid << 32 | \ 172c172 < (_FMT_)((int64_t)current->pid << 32 | \ --- > (_FMT_)((int64_t)current->tgid << 32 | \ a patch committed for this bug. Please try to see if it still has problems. I did a test for both dumping into local file and into mysql database, and they works fine for me. LKET has been retired. |