Summary: | Setuid implementation has races and lockups | ||
---|---|---|---|
Product: | glibc | Reporter: | Daniel Jacobowitz <drow> |
Component: | nptl | Assignee: | Ulrich Drepper <drepper.fsp> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | fweimer, glibc-bugs, null, pasky, samandbernie, wade.colson |
Priority: | P2 | Flags: | fweimer:
security+
|
Version: | 2.4 | ||
Target Milestone: | --- | ||
Host: | x86_64-pc-linux-gnu | Target: | |
Build: | Last reconfirmed: | ||
Attachments: |
Testcase.
Patch. Updated patch |
Description
Daniel Jacobowitz
2006-09-27 15:37:10 UTC
Created attachment 1329 [details]
Testcase.
This test illustrates the problem, but not reliably. I have to run about
twenty copies of it in parallel; some of them will exit after 3000 iterations,
others will remain blocked with one thread in pthread_join.
Created attachment 1330 [details] Patch. This patch fixes the problem; testsuite run on x86_64-pc-linux-gnu, no regressions. It makes the setuid path slightly slower but has no effect on the non-setuid path, unlike my earlier attempts. An earlier version of this patch with more assertions triggered this kernel bug: http://bugzilla.kernel.org/show_bug.cgi?id=7210 A fix to that is not necessary for this version of the patch, but I recommend it anyway. We seem to have hit this problem on our large cluster -- when we run 5500 jobs of "seq 10" without this patch, our slurm process manager hangs. Just adding this patch to glibc with no other changes, and 200 runs of the 5500 parallel jobs of "seq 10" works OK. Any chance this patch could be considered for a glibc release? We also encounter this problem with the product we are providing. I would want to know if this issue is now fixed. And if yes, the glibc level in which the fix has been added. We have customers using our product on Linux platforms with a glibc level containing this issue. Thank you very much. *** Bug 10184 has been marked as a duplicate of this bug. *** Created attachment 4339 [details]
Updated patch
I've applied the patch. I don't like it but it can be changed later. *** Bug 260998 has been marked as a duplicate of this bug. *** Seen from the domain http://volichat.com Page where seen: http://volichat.com/chat-with-strangers Marked for reference. Resolved as fixed @bugzilla. |