| Summary: | incorrect logger use in frysk.rt.StackCallbacks.java | ||
|---|---|---|---|
| Product: | frysk | Reporter: | Andrew Cagney <cagney> |
| Component: | general | Assignee: | Unassigned <frysk-bugzilla> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ajocksch, mcvet, qiyaoltc, woodzltc, zhengyo |
| Priority: | P2 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Host: | Target: | ||
| Build: | Last reconfirmed: | ||
| Bug Depends on: | |||
| Bug Blocks: | 2935, 3076 | ||
Fixed January 11, 2007 frysk-core/frysk/rt/CL * StackCallbacks.java (accessReg): Use logger formatting mechanism, bug #3216 (accessFpreg): Ditto. (getPid): Ditto. (writeFpreg): Ditto. (writeMem): Ditto. (accessMem): Ditto. Cleaned up some excessive logging junk. (writeReg): Ditto. |
The file contains: logger.log(Level.FINE, "Libunwind: findProcInfo for 0x" + Long.toHexString(instructionAddress) + "\n"); (it also contained references to frysk.proc.Host.logger, but that is another story :-), in particular, note the use of the << + >> operator. That causes the allocation of a StringBuffer even when there's no log message. The code should instead use the logger's formatting mechanism. (It's suspected that the code was simply translated from System.out.println calls).