| Summary: | frv_current_sos doesn't set solib::lm_info | ||
|---|---|---|---|
| Product: | gdb | Reporter: | Simon Marchi <simark> |
| Component: | gdb | Assignee: | Not yet assigned to anyone <unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | brobecker, simon.marchi |
| Priority: | P2 | ||
| Version: | HEAD | ||
| Target Milestone: | 15.2 | ||
| Host: | Target: | ||
| Build: | Last reconfirmed: | ||
The master branch has been updated by Simon Marchi <simark@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5a2f7d248a50a868152cb357dd05ebcd860ac244 commit 5a2f7d248a50a868152cb357dd05ebcd860ac244 Author: Simon Marchi <simon.marchi@efficios.com> Date: Mon Jul 22 10:42:49 2024 -0400 gdb/solib-frv: move lm_info object to solib I noticed that the lm_info_frv objects created in frv_current_sos are never moved to the solib object. This bug was introduced in 8971d2788e ("gdb: link so_list using intrusive_list"), which mistakenly removed the line sop->lm_info = std::move (li); ... probably due so a bad merge conflict resolution. Re-add this line. If merged in master, I would cherry-pick this to gdb-15-branch. Change-Id: I609a1a5ad39e93f70a95ea5ebe3f8ff4ab6a8db2 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32005 Approved-By: Andrew Burgess <aburgess@redhat.com> The gdb-15-branch branch has been updated by Simon Marchi <simark@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=760242224fba975216ec894e5537aa93c72006a6 commit 760242224fba975216ec894e5537aa93c72006a6 Author: Simon Marchi <simon.marchi@efficios.com> Date: Mon Jul 22 10:42:49 2024 -0400 gdb/solib-frv: move lm_info object to solib I noticed that the lm_info_frv objects created in frv_current_sos are never moved to the solib object. This bug was introduced in 8971d2788e ("gdb: link so_list using intrusive_list"), which mistakenly removed the line sop->lm_info = std::move (li); ... probably due so a bad merge conflict resolution. Re-add this line. If merged in master, I would cherry-pick this to gdb-15-branch. Change-Id: I609a1a5ad39e93f70a95ea5ebe3f8ff4ab6a8db2 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32005 Approved-By: Andrew Burgess <aburgess@redhat.com> Fixed. FTR - I'm the one who changed the Target Milestone to 15.2 in order to record the fact that the fix was pushed to 15.2 (as well as master). |
I noticed that the lm_info_frv objects created in frv_current_sos are never moved to the solib object. This bug was introduced in 8971d2788e ("gdb: link so_list using intrusive_list"), which mistakenly removed the line sop->lm_info = std::move (li); ... probably due so a bad merge conflict resolution. I will fix that and propose cherry-picking the fix to gdb-15-branch.