Bug 30649

Summary: [PATCH] Add transliteration of common emojis to smileys
Product: glibc Reporter: Colin Leroy-Mira <colin>
Component: localedataAssignee: Not yet assigned to anyone <unassigned>
Status: RESOLVED FIXED    
Severity: enhancement CC: bruno, carlos, fweimer, libc-locales, sam
Priority: P2 Flags: fweimer: security-
Version: unspecified   
Target Milestone: 2.39   
Host: Target:
Build: Last reconfirmed: 2023-07-18 00:00:00
Project(s) to access: ssh public key:
Attachments: Patch against git
Example of transliteration
Correct patch against git

Description Colin Leroy-Mira 2023-07-18 09:55:22 UTC
Created attachment 14980 [details]
Patch against git

Hello,

This patch adds transliteration of common emojis (faces and hearts) to old-school, ASCII-compliant smileys.

I hope you'll consider it for inclusion! 

Thanks,

Colin
Comment 1 Colin Leroy-Mira 2023-07-18 09:56:44 UTC
Created attachment 14981 [details]
Example of transliteration

An example of the result
Comment 2 Colin Leroy-Mira 2023-07-18 10:03:10 UTC
Created attachment 14982 [details]
Correct patch against git

Sorry, first patch was the wrong commit.
Comment 3 Bruno Haible 2023-07-18 10:26:43 UTC
Very nice!
Comment 4 Carlos O'Donell 2023-07-18 12:25:10 UTC
(In reply to Colin Leroy-Mira from comment #2)
> Created attachment 14982 [details]
> Correct patch against git
> 
> Sorry, first patch was the wrong commit.

Thanks for all of the work on this.

Could you please post your patch to libc-alpha@sourceware.org for review?

The contribution checklist walks you through the process:
https://sourceware.org/glibc/wiki/Contribution%20checklist
Comment 5 Colin Leroy-Mira 2023-07-18 12:50:13 UTC
Thank you for the pointer Carlos, I will do that.
Comment 6 Florian Weimer 2023-08-29 07:43:21 UTC
Fixed for 2.39 via:

commit dfe8c445883a50a55564b02b6957257bfc510db4
Author: Colin Leroy-Mira <colin@colino.net>
Date:   Tue Aug 29 08:02:50 2023 +0200

    localedata: Translit common emojis to smileys [BZ #30649]
    
    Add common emojis to the translit-able characters (mostly
    faces and hearts), and translit them to old-fashioned
    smileys.
    
    Signed-off-by: Colin Leroy-Mira <colin@colino.net>
    Reviewed-by: Florian Weimer <fweimer@redhat.com>