Bug 28972

Summary:	gprofng libraries should be installed under $(pkglibdir)
Product:	binutils	Reporter:	H.J. Lu <hjl.tools>
Component:	gprofng	Assignee:	Vladimir Mezentsev <vladimir.mezentsev>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kurt.goebel, matz, sam
Priority:	P2
Version:	2.39
Target Milestone:	2.39
See Also:	https://sourceware.org/bugzilla/show_bug.cgi?id=30043
Host:		Target:
Build:		Last reconfirmed:

Description H.J. Lu 2022-03-16 17:21:03 UTC

Currently gprofng libraries are installed under $(libdir).  I
believe that they should be installed under $(pkglibdir).

Comment 1 Sourceware Commits 2022-03-22 02:43:26 UTC

The master branch has been updated by H.J. Lu <hjl@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6c924cf21caae1d6f277d281eb276b2bab2ef4ba

commit 6c924cf21caae1d6f277d281eb276b2bab2ef4ba
Author: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
Date:   Thu Mar 17 09:57:28 2022 -0700

    Install gprofng libraries under $(pkglibdir)
    
    gprofng/ChangeLog
    2022-03-21  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>
    
            PR gprofng/28972
            * gprofng/libcollector/Makefile.am: Rename lib_LTLIBRARIES to
            pkglib_LTLIBRARIES. Add install-data-local.
            * gprofng/src/Makefile.am: Likewise.
            * gprofng/src/envsets.cc (putenv_libcollector_ld_misc): New location of
            the gprofng libraries.
            * gprofng/configure.ac: Removed an unused GPROFNG_LIBDIR.
            * gprofng/Makefile.am: Removed an unused GPROFNG_LIBDIR.  Add
            install-data-local.
            * gprofng/configure: Regenerate.
            * gprofng/Makefile.in: Likewise.
            * gprofng/doc/Makefile.in: Likewise.
            * gprofng/gp-display-htmllibcollector/Makefile.in: Likewise.
            * gprofng/libcollector/Makefile.in: Likewise.
            * gprofng/src/Makefile.in: Likewise.

Comment 2 H.J. Lu 2022-03-22 02:51:21 UTC

Fixed.

Comment 3 Michael Matz 2023-01-25 14:13:49 UTC

This was wrong advise.  The shared _modules_ (the collectors, those which are
loaded by dlopen) should indeed be placed in $(pkglibdir).  But the shared _library_ libgprofng.so.0 (and its various symlinks) need to stay in $(libdir).

Comment 4 Sourceware Commits 2023-01-26 19:05:15 UTC

The master branch has been updated by Vladimir Mezentsev <vmezents@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2b304f501f1fe7ca0a27a6e672fd9cf8f289b4eb

commit 2b304f501f1fe7ca0a27a6e672fd9cf8f289b4eb
Author: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
Date:   Wed Jan 25 19:21:38 2023 -0800

    gprofng: PR30043 libgprofng.so.* are installed to a wrong location
    
    gprofng/ChangeLog
    2023-01-25  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>
    
            PR gprofng/30043
            PR gprofng/28972
            * src/Makefile.am: Use lib_LTLIBRARIES instead of pkglib_LTLIBRARIES.
            * src/Makefile.in: Rebuild.

Comment 5 Sourceware Commits 2023-01-26 19:57:40 UTC

The binutils-2_40-branch branch has been updated by Vladimir Mezentsev <vmezents@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=edd36b26f3506eeb259534ba2493e15c728cd280

commit edd36b26f3506eeb259534ba2493e15c728cd280
Author: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
Date:   Wed Jan 25 19:21:38 2023 -0800

    gprofng: PR30043 libgprofng.so.* are installed to a wrong location
    
    gprofng/ChangeLog
    2023-01-25  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>
    
            PR gprofng/30043
            PR gprofng/28972
            * src/Makefile.am: Use lib_LTLIBRARIES instead of pkglib_LTLIBRARIES.
            * src/Makefile.in: Rebuild.

Comment 6 Vladimir Mezentsev 2023-02-01 20:32:40 UTC

Fixed in the master and binutils-2_40-branch branches.